[webkit-changes] [WebKit/WebKit] ffe47a: Textarea placeholder text does not disappear when ...

Ahmad Saleem noreply at github.com
Wed Nov 30 18:11:58 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ffe47a6f01ddccf0a295321b0b5270f1fb93db1c
      https://github.com/WebKit/WebKit/commit/ffe47a6f01ddccf0a295321b0b5270f1fb93db1c
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-11-30 (Wed, 30 Nov 2022)

  Changed paths:
    A LayoutTests/fast/forms/textarea/textarea-placeholder-visibility-3-expected.html
    A LayoutTests/fast/forms/textarea/textarea-placeholder-visibility-3.html
    M Source/WebCore/html/HTMLTextAreaElement.cpp

  Log Message:
  -----------
  Textarea placeholder text does not disappear when inserting text without a user gesture

Textarea placeholder text does not disappear when inserting text without a user gesture
https://bugs.webkit.org/show_bug.cgi?id=248526

Reviewed by Aditya Keerthi.

This patch is to align Webkit with Gecko / Firefox and Blink / Chromium.

Merge - https://src.chromium.org/viewvc/blink?view=revision&revision=195023

This patch is adding add condition for "subtreeHasChanged" function to update
placeholder visibility after the text is insert via execCommand / JavaScript
without user interaction.

* Source/WebCore/html/HTMLTextareaElement.cpp:
(HTMLTextAreaElement::subtreeHasChanged): Add logic to update Placeholder Visibility
* LayoutTests/fast/forms/textarea/textarea-placeholder-visisbility-3.html: Add Test Case
* LayoutTests/fast/forms/textarea/textarea-placeholder-visisbility-3-expected.html: Add Test Case Expectation

Canonical link: https://commits.webkit.org/257210@main




More information about the webkit-changes mailing list