[webkit-changes] [WebKit/WebKit] b83027: Potential crash fix by bailing from DeleteSelectio...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b83027e6d7d01b7ec451b6086430aed994c2ed12
      https://github.com/WebKit/WebKit/commit/b83027e6d7d01b7ec451b6086430aed994c2ed12
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-11-30 (Wed, 30 Nov 2022)

  Changed paths:
    A LayoutTests/editing/execCommand/delete-non-editable-range-crash-expected.txt
    A LayoutTests/editing/execCommand/delete-non-editable-range-crash.html
    M Source/WebCore/editing/DeleteSelectionCommand.cpp

  Log Message:
  -----------
  Potential crash fix by bailing from DeleteSelectionCommand::doApply when selection isn't editable

Potential crash fix by bailing from DeleteSelectionCommand::doApply when selection isn't editable
https://bugs.webkit.org/show_bug.cgi?id=248486

Reviewed by Ryosuke Niwa.

Merge - https://src.chromium.org/viewvc/blink?view=revision&revision=190121

This patch is to harden the function doApply() by bailing early by ensuring the selection to delete is not editable.

* Source/WebCore/editing/DeleteSelectionCommand.cpp:
(DeleteSelectionCommand::doApply): Add condition about selection being non-editable
* LayoutTests/editing/execCommand/delete-non-editable-range-crash.html: Add Test Case
* LayoutTests/editing/execCommand/delete-non-editable-range-crash-expected.txt: Add Test Case Expectations

Canonical link: https://commits.webkit.org/257203@main