[webkit-changes] [WebKit/WebKit] a3b85f: FrameView::mediaType() should be AtomString

Antti Koivisto noreply at github.com
Wed Nov 30 08:16:20 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a3b85f8344f9138c7d587e66aa4e8c33ac79ec2c
      https://github.com/WebKit/WebKit/commit/a3b85f8344f9138c7d587e66aa4e8c33ac79ec2c
  Author: Antti Koivisto <antti at apple.com>
  Date:   2022-11-30 (Wed, 30 Nov 2022)

  Changed paths:
    M Source/WebCore/css/MediaQueryMatcher.cpp
    M Source/WebCore/css/MediaQueryMatcher.h
    M Source/WebCore/css/parser/SizesAttributeParser.cpp
    M Source/WebCore/css/query/MediaQueryEvaluator.cpp
    M Source/WebCore/css/query/MediaQueryFeatures.cpp
    M Source/WebCore/css/query/MediaQueryParser.cpp
    M Source/WebCore/html/HTMLImageElement.cpp
    M Source/WebCore/html/HTMLLinkElement.cpp
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/html/HTMLMetaElement.cpp
    M Source/WebCore/inspector/InspectorInstrumentation.cpp
    M Source/WebCore/inspector/InspectorInstrumentation.h
    M Source/WebCore/inspector/agents/InspectorPageAgent.cpp
    M Source/WebCore/inspector/agents/InspectorPageAgent.h
    M Source/WebCore/loader/EmptyClients.cpp
    M Source/WebCore/loader/EmptyFrameLoaderClient.h
    M Source/WebCore/loader/FrameLoaderClient.h
    M Source/WebCore/page/FrameView.cpp
    M Source/WebCore/page/FrameView.h
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/SettingsBase.cpp
    M Source/WebCore/platform/CommonAtomStrings.h
    M Source/WebCore/style/StyleResolver.cpp
    M Source/WebCore/style/UserAgentStyle.cpp
    M Source/WebCore/svg/SVGStyleElement.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm
    M Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.cpp
    M Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.h

  Log Message:
  -----------
  FrameView::mediaType() should be AtomString
https://bugs.webkit.org/show_bug.cgi?id=248464
<rdar://problem/102805167>

Reviewed by Antoine Quint.

Also add atoms for the common values "screen", "print" and "all".

* Source/WebCore/css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::mediaType const):
* Source/WebCore/css/MediaQueryMatcher.h:
* Source/WebCore/css/parser/SizesAttributeParser.cpp:
(WebCore::SizesAttributeParser::mediaConditionMatches):
(WebCore::SizesAttributeParser::parse):
* Source/WebCore/css/query/MediaQueryEvaluator.cpp:
(WebCore::MQ::MediaQueryEvaluator::evaluateMediaType const):
(WebCore::MQ::MediaQueryEvaluator::isPrintMedia const):
* Source/WebCore/css/query/MediaQueryFeatures.cpp:
(WebCore::MQ::Features::deviceScaleFactor):
* Source/WebCore/css/query/MediaQueryParser.cpp:
(WebCore::MQ::MediaQueryParser::parseCondition):
(WebCore::MQ::MediaQueryParser::consumeMediaQueryList):
(WebCore::MQ::serialize):
* Source/WebCore/html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
(WebCore::HTMLImageElement::evaluateDynamicMediaQueryDependencies):
* Source/WebCore/html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::mediaAttributeMatches const):
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::selectNextSourceChild):
* Source/WebCore/html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::mediaAttributeMatches):
* Source/WebCore/page/FrameView.cpp:
(WebCore::FrameView::setMediaType):
(WebCore::FrameView::mediaType const):
(WebCore::FrameView::adjustMediaTypeForPrinting):
* Source/WebCore/page/FrameView.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::useDarkAppearance const):
* Source/WebCore/page/SettingsBase.cpp:
(WebCore::SettingsBase::mediaTypeOverrideChanged):
* Source/WebCore/platform/CommonAtomStrings.h:
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::Resolver::Resolver):
* Source/WebCore/style/UserAgentStyle.cpp:
(WebCore::Style::screenEval):
(WebCore::Style::printEval):
* Source/WebCore/svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::media const):

Canonical link: https://commits.webkit.org/257181@main




More information about the webkit-changes mailing list