[webkit-changes] [WebKit/WebKit] 5e81d3: Only send one drawing command per list marker

Ahmad Saleem noreply at github.com
Wed Nov 30 03:40:22 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5e81d33ff5c0150dbabbebbe2e96fb08ff4d6ad3
      https://github.com/WebKit/WebKit/commit/5e81d33ff5c0150dbabbebbe2e96fb08ff4d6ad3
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-11-30 (Wed, 30 Nov 2022)

  Changed paths:
    A LayoutTests/fast/lists/list-type-translucent-color-expected.html
    A LayoutTests/fast/lists/list-type-translucent-color.html
    M Source/WebCore/rendering/RenderListMarker.cpp

  Log Message:
  -----------
  Only send one drawing command per list marker

Only send one drawing command per list marker
https://bugs.webkit.org/show_bug.cgi?id=248378

Reviewed by Tim Nguyen.

Merge - https://src.chromium.org/viewvc/blink?view=revision&revision=151161

Previously, some list markers (notably list-style-type: disc, circle, square)
would send two drawing commands per marker: one to fill the marker, and
then a second one to fill it. This constructs unnecessary paints and causes
a weird visual effect if the color is translucent.

This should have a minor visible effect on these list markers, but it's not
identical: since the stroke area isn't drawn again, the antialiasing varies.

* Source/WebCore/rendering/RenderListMarker.cpp:
(RenderListMarker::paint): Update draw to fill or stroke for "disc", "circle" and "square"
* LayoutTests/fast/lists/list-type-translucent-color.html: Added Test Case
* LayoutTests/fast/lists/list-type-translucent-color-expected.html: Added Test Case Expectation

Canonical link: https://commits.webkit.org/257175@main




More information about the webkit-changes mailing list