[webkit-changes] [WebKit/WebKit] 2d8a92: Manually invalidate the FontCache before clearing ...

mattwoodrow noreply at github.com
Tue Nov 29 20:57:47 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2d8a9204f770ff652583b404b5b3cf4a047cad17
      https://github.com/WebKit/WebKit/commit/2d8a9204f770ff652583b404b5b3cf4a047cad17
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2022-11-29 (Tue, 29 Nov 2022)

  Changed paths:
    M Source/WebCore/platform/ThreadGlobalData.cpp
    M Source/WebCore/platform/ThreadGlobalData.h
    M Source/WebCore/platform/graphics/FontCache.h

  Log Message:
  -----------
  Manually invalidate the FontCache before clearing ThreadGlobalData.
https://bugs.webkit.org/show_bug.cgi?id=248502

Reviewed by Cameron McCormack.

Destructing the FontCache can recurse back into the ThreadGlobalData getter (to remove cached entries), so
we want to manually clear the FontCache before clearing the ThreadGlobalData pointer.

This also moves m_destroyed to earlier in the class, so it's guaranteed to be destructed after m_fontCache.

* Source/WebCore/platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::destroy):
* Source/WebCore/platform/ThreadGlobalData.h:
* Source/WebCore/platform/graphics/FontCache.h:

Canonical link: https://commits.webkit.org/257160@main




More information about the webkit-changes mailing list