[webkit-changes] [WebKit/WebKit] fcfa00: Cherry-pick 9b75120909b0. rdar://problem/102120764

Yusuke Suzuki noreply at github.com
Tue Nov 29 15:50:13 PST 2022


  Branch: refs/heads/safari-7615.1.13-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: fcfa0037c65915222a6e6f5e701d1b802605855b
      https://github.com/WebKit/WebKit/commit/fcfa0037c65915222a6e6f5e701d1b802605855b
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2022-11-29 (Tue, 29 Nov 2022)

  Changed paths:
    M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp

  Log Message:
  -----------
  Cherry-pick 9b75120909b0. rdar://problem/102120764

    [JSC] reading scratch-buffer is not pure-function call
    https://bugs.webkit.org/show_bug.cgi?id=248453
    rdar://102120764

    Reviewed by Mark Lam.

    We should not use callWithoutSideEffects for operationArithMinMultipleDouble / operationArithMaxMultipleDouble
    calls since they read ScratchBuffer memory, thus they are not pure functions. They depend on content of ScratchBuffer.
    So, even if ScratchBuffer's address is the same, then the result depends on its content. Use vmCall instead.

    * Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
    (JSC::FTL::DFG::LowerDFGToB3::compileArithMinOrMax):

    Canonical link: https://commits.webkit.org/257102@main

Canonical link: https://commits.webkit.org/257041.5@safari-7615.1.13-branch




More information about the webkit-changes mailing list