[webkit-changes] [WebKit/WebKit] 24455f: [JSC] Wasm test regressions on 32-bit ARM after 25...

aoikonomopoulos noreply at github.com
Tue Nov 29 07:13:56 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 24455f01485116bf93e8b750e86691c44d70230d
      https://github.com/WebKit/WebKit/commit/24455f01485116bf93e8b750e86691c44d70230d
  Author: Angelos Oikonomopoulos <angelos at igalia.com>
  Date:   2022-11-29 (Tue, 29 Nov 2022)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmTypeDefinition.h
    M Source/JavaScriptCore/wasm/generateWasmOpsHeader.py

  Log Message:
  -----------
  [JSC] Wasm test regressions on 32-bit ARM after 256472 at main
https://bugs.webkit.org/show_bug.cgi?id=247886

Reviewed by Yusuke Suzuki.

Testing if the index is < 0 is not appropriate on 32-bit ARM.
Define and use minTypeValue instead.

Implementing https://bugs.webkit.org/show_bug.cgi?id=247454 would be a
better medium-term fix.

* Source/JavaScriptCore/wasm/WasmTypeDefinition.h:
(JSC::Wasm::Type::dump const):
* Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:

Canonical link: https://commits.webkit.org/257116@main




More information about the webkit-changes mailing list