[webkit-changes] [WebKit/WebKit] f3dfd0: REGRESSION (255903 at main): iWork/Numbers/Pages Keyn...

Nikos Mouchtaris noreply at github.com
Mon Nov 28 16:51:53 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f3dfd0cc716eec21249cf1b3544fff9303053a0a
      https://github.com/WebKit/WebKit/commit/f3dfd0cc716eec21249cf1b3544fff9303053a0a
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2022-11-28 (Mon, 28 Nov 2022)

  Changed paths:
    R LayoutTests/fast/attachment/mac/attachment-element-gpu-process-expected.html
    R LayoutTests/fast/attachment/mac/attachment-element-gpu-process.html
    M Source/WebCore/SourcesCocoa.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    R Source/WebCore/rendering/AttachmentLayout.h
    M Source/WebCore/rendering/RenderTheme.cpp
    M Source/WebCore/rendering/RenderTheme.h
    M Source/WebCore/rendering/RenderThemeCocoa.h
    M Source/WebCore/rendering/RenderThemeCocoa.mm
    M Source/WebCore/rendering/RenderThemeIOS.h
    M Source/WebCore/rendering/RenderThemeIOS.mm
    M Source/WebCore/rendering/RenderThemeMac.h
    M Source/WebCore/rendering/RenderThemeMac.mm

  Log Message:
  -----------
  REGRESSION (255903 at main): iWork/Numbers/Pages Keynote attachments appear upside down
https://bugs.webkit.org/show_bug.cgi?id=248421
<rdar://102052562>

Unreviewed revert.

Revert 255903 at main.

* LayoutTests/fast/attachment/mac/attachment-element-gpu-process-expected.html: Removed.
* LayoutTests/fast/attachment/mac/attachment-element-gpu-process.html: Removed.
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/rendering/AttachmentLayout.h: Removed.
* Source/WebCore/rendering/AttachmentLayout.mm: Removed.
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
* Source/WebCore/rendering/RenderTheme.h:
(WebCore::RenderTheme::paintAttachmentText): Deleted.
* Source/WebCore/rendering/RenderThemeCocoa.h:
* Source/WebCore/rendering/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::attachmentBaseline const): Deleted.
(WebCore::RenderThemeCocoa::paintAttachmentText): Deleted.
* Source/WebCore/rendering/RenderThemeIOS.h:
* Source/WebCore/rendering/RenderThemeIOS.mm:
(WebCore::attachmentActionFont):
(WebCore::attachmentActionColor):
(WebCore::attachmentTitleFont):
(WebCore::shortCaptionPointSizeWithContentSizeCategory):
(WebCore::attachmentDynamicTypeScaleFactor):
(WebCore::attachmentTitleColor):
(WebCore::attachmentSubtitleFont):
(WebCore::attachmentSubtitleColor):
(WebCore::RenderAttachmentInfo::addLine):
(WebCore::RenderAttachmentInfo::buildWrappedLines):
(WebCore::RenderAttachmentInfo::buildSingleLine):
(WebCore::getAttachmentProgress):
(WebCore::RenderAttachmentInfo::RenderAttachmentInfo):
(WebCore::RenderThemeIOS::attachmentBaseline const):
(WebCore::paintAttachmentIcon):
(WebCore::paintAttachmentText):
(WebCore::paintAttachmentProgress):
(WebCore::attachmentBorderPath):
(WebCore::RenderThemeIOS::paintAttachment):
* Source/WebCore/rendering/RenderThemeMac.h:
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::titleTextColorForAttachment):
(WebCore::AttachmentLayout::addTitleLine):
(WebCore::AttachmentLayout::layOutTitle):
(WebCore::AttachmentLayout::layOutSubtitle):
(WebCore::AttachmentLayout::AttachmentLayout):
(WebCore::RenderThemeMac::attachmentBaseline const):
(WebCore::paintAttachmentIcon):
(WebCore::paintAttachmentTitle):
(WebCore::paintAttachmentSubtitle):
(WebCore::RenderThemeMac::paintAttachment):

Canonical link: https://commits.webkit.org/257095@main




More information about the webkit-changes mailing list