[webkit-changes] [WebKit/WebKit] b9824f: EWS should use results database instead of doing c...

Aakash J noreply at github.com
Mon Nov 28 14:44:42 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b9824fc290ac9247e8a04f38632a8fdd4b9ec02d
      https://github.com/WebKit/WebKit/commit/b9824fc290ac9247e8a04f38632a8fdd4b9ec02d
  Author: Aakash Jain <aakash_jain at apple.com>
  Date:   2022-11-28 (Mon, 28 Nov 2022)

  Changed paths:
    M Tools/CISupport/ews-build/results_db.py
    M Tools/CISupport/ews-build/steps.py
    M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  -----------
  EWS should use results database instead of doing clean-tree runs
https://bugs.webkit.org/show_bug.cgi?id=204368
rdar://82975679

Reviewed by Jonathan Bedard.

Pre-existing test failures signficantly slow down EWS, and this change attempts to speed up EWS
by consulting results database. EWS will now consult results database for the test failures which were noticed.
If those test were also failing/flaky in results db, then we ignore those failures in EWS run. Othewise, EWS will
continue with the existing logic of retry/clean-tree-run.

* Tools/CISupport/ews-build/results_db.py:
(ResultsDatabase.get_results_summary): Updated the method to not print logs, instead return them to the caller.
(ResultsDatabase.is_test_flaky_or_pre_existing): Wrapper method which contains the logic to declare if test is flaky/pre-existing or not.
* Tools/CISupport/ews-build/steps.py:
(RunWebKitTests.commandComplete):
(RunWebKitTests.filter_failures_using_results_db): Method which filters the test failures based on info from results db.
(RunWebKitTests.evaluateCommand):
(RunWebKitTests.getResultSummary):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/257090@main




More information about the webkit-changes mailing list