[webkit-changes] [WebKit/WebKit] b564ed: Remove StyleProperties::textDecorationSkipValue()

Tim Nguyen noreply at github.com
Mon Nov 28 04:44:23 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b564ed1fb7d6716892d3931b5401fba3c9ed02f7
      https://github.com/WebKit/WebKit/commit/b564ed1fb7d6716892d3931b5401fba3c9ed02f7
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2022-11-28 (Mon, 28 Nov 2022)

  Changed paths:
    M Source/WebCore/css/StyleProperties.cpp
    M Source/WebCore/css/StyleProperties.h

  Log Message:
  -----------
  Remove StyleProperties::textDecorationSkipValue()
https://bugs.webkit.org/show_bug.cgi?id=248386
rdar://102708232

Reviewed by Antti Koivisto.

text-decoration-skip can share the serialization handling with other shorthands with single longhands.

- We don't ever need to serialize `ink` because it gets changed to `auto` at parse-time
- We don't need to take care of implicit property references, since we never add text-decoration-skip-ink as implicit in `consumeTextDecorationSkip()`.

This part of an effort to remove the implicit flag for property references.

* Source/WebCore/css/StyleProperties.cpp:
(WebCore::StyleProperties::getPropertyValue const):
(WebCore::canUseShorthandForLonghand):
(WebCore::StyleProperties::textDecorationSkipValue const): Deleted.
* Source/WebCore/css/StyleProperties.h:

Canonical link: https://commits.webkit.org/257067@main




More information about the webkit-changes mailing list