[webkit-changes] [WebKit/WebKit] 121756: [CMake] Use CMAKE_MSVC_RUNTIME_LIBRARY to select a...

Fujii Hironori noreply at github.com
Sun Nov 27 16:48:32 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 121756da7448caa31c54f128bcf8cdefe774963d
      https://github.com/WebKit/WebKit/commit/121756da7448caa31c54f128bcf8cdefe774963d
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2022-11-27 (Sun, 27 Nov 2022)

  Changed paths:
    M CMakeLists.txt
    M Source/JavaScriptCore/CMakeLists.txt
    M Source/WTF/CMakeLists.txt
    M Source/WebCore/CMakeLists.txt
    M Source/WebKitLegacy/CMakeLists.txt
    M Source/cmake/OptionsAppleWin.cmake
    M Source/cmake/OptionsMSVC.cmake
    M Source/cmake/OptionsWinCairo.cmake

  Log Message:
  -----------
  [CMake] Use CMAKE_MSVC_RUNTIME_LIBRARY to select a CRT type instead of regexp replacing
https://bugs.webkit.org/show_bug.cgi?id=248289

Reviewed by Don Olmstead.

Regexp replacing has been used to change a CRT type for Windows. CMake
3.15 introduced CMAKE_MSVC_RUNTIME_LIBRARY for it.
<https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html>

There was a code to remove _DEBUG macro definition from
CMAKE_{C,CXX}_FLAGS* variables. However, those variables don't include
it. _DEBUG macro is automatically defined by -MDd and -MTd switches.
Removed the code.

Bumped cmake_minimum_required version to 3.16 to use
target_precompile_headers (bug#248202).

* CMakeLists.txt: Source/JavaScriptCore/CMakeLists.txt:
* Source/WTF/CMakeLists.txt: Source/WebCore/CMakeLists.txt:
* Source/WebKitLegacy/CMakeLists.txt:
* Source/cmake/OptionsAppleWin.cmake: Source/cmake/OptionsMSVC.cmake:
* Source/cmake/OptionsWinCairo.cmake:

Canonical link: https://commits.webkit.org/257053@main




More information about the webkit-changes mailing list