[webkit-changes] [WebKit/WebKit] 7602b2: [web-animations] move scheduledTime from Animation...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7602b29151e9b209f256945d6221b2943ca21f57
      https://github.com/WebKit/WebKit/commit/7602b29151e9b209f256945d6221b2943ca21f57
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2022-11-27 (Sun, 27 Nov 2022)

  Changed paths:
    M Source/WebCore/animation/AnimationEventBase.cpp
    M Source/WebCore/animation/AnimationEventBase.h
    M Source/WebCore/animation/AnimationPlaybackEvent.cpp
    M Source/WebCore/animation/AnimationPlaybackEvent.h
    M Source/WebCore/animation/CSSAnimation.cpp
    M Source/WebCore/animation/CSSAnimationEvent.cpp
    M Source/WebCore/animation/CSSAnimationEvent.h
    M Source/WebCore/animation/CSSTransition.cpp
    M Source/WebCore/animation/CSSTransitionEvent.cpp
    M Source/WebCore/animation/CSSTransitionEvent.h
    M Source/WebCore/animation/DeclarativeAnimationEvent.cpp
    M Source/WebCore/animation/DeclarativeAnimationEvent.h
    M Source/WebCore/animation/WebAnimation.cpp

  Log Message:
  -----------
  [web-animations] move scheduledTime from AnimationPlaybackEvent to AnimationEventBase
https://bugs.webkit.org/show_bug.cgi?id=248374

Reviewed by Sam Weinig.

Currently only AnimationPlaybackEvent has the notion of a scheduled event time but, in order to fix bug 235145,
we'll need to add that notion to CSS Animations and CSS Transitions events as well. So it would make sense to
promote it to AnimationEventBase such that all the animation event subclasses benefit from it.

We currently pass std::nullopt for the scheduled event time value when creating CSSAnimationEvent
and CSSTransitionEvent but we will soon compute a resolved value for the patch to bug 235145.

* Source/WebCore/animation/AnimationEventBase.cpp:
(WebCore::AnimationEventBase::AnimationEventBase):
* Source/WebCore/animation/AnimationEventBase.h:
(WebCore::AnimationEventBase::scheduledTime const):
(WebCore::AnimationEventBase::create): Deleted.
* Source/WebCore/animation/AnimationPlaybackEvent.cpp:
(WebCore::AnimationPlaybackEvent::AnimationPlaybackEvent):
* Source/WebCore/animation/AnimationPlaybackEvent.h:
* Source/WebCore/animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::createEvent):
* Source/WebCore/animation/CSSAnimationEvent.cpp:
(WebCore::CSSAnimationEvent::CSSAnimationEvent):
* Source/WebCore/animation/CSSAnimationEvent.h:
* Source/WebCore/animation/CSSTransition.cpp:
(WebCore::CSSTransition::createEvent):
* Source/WebCore/animation/CSSTransitionEvent.cpp:
(WebCore::CSSTransitionEvent::CSSTransitionEvent):
* Source/WebCore/animation/CSSTransitionEvent.h:
* Source/WebCore/animation/DeclarativeAnimationEvent.cpp:
(WebCore::DeclarativeAnimationEvent::DeclarativeAnimationEvent):
* Source/WebCore/animation/DeclarativeAnimationEvent.h:
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::enqueueAnimationPlaybackEvent):

Canonical link: https://commits.webkit.org/257048@main