[webkit-changes] [WebKit/WebKit] 5f95c4: Refactor testdriver-vendor.js to make better use o...

[Marcos Cáceres]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5f95c4f4489da355e5c59a0d7f7877c8f081222d
      https://github.com/WebKit/WebKit/commit/5f95c4f4489da355e5c59a0d7f7877c8f081222d
  Author: Marcos Caceres <marcos at marcosc.com>
  Date:   2022-11-25 (Fri, 25 Nov 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-custom-formats-write-read.tentative.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-html-script-removal.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-navigator-clipboard-read-resource-load.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-navigator-clipboard-read-sanitize.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-promise-write-blobs-read-blobs.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-svg-script-removal.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-unsanitized-html-formats-write-read.tentative.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-unsanitized-plaintext-formats-write-read.tentative.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-write-blobs-read-blobs.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-write-html-read-html.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-write-image-read-image.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-write-svg-read-svg.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/detached-iframe/read-on-detaching-iframe.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/detached-iframe/write-on-detaching-iframe.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/detached-iframe/write-read-on-detached-iframe.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/detached-iframe/writeText-readText-on-detached-iframe.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/feature-policy/clipboard-write/clipboard-write-disabled-by-feature-policy.tentative.https.sub-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/feature-policy/clipboard-write/clipboard-write-enabled-by-feature-policy.tentative.https.sub-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/feature-policy/clipboard-write/clipboard-write-enabled-on-self-origin-by-feature-policy.tentative.https.sub-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/permissions/readText-denied.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/permissions/readText-granted.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/permissions/writeText-denied.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/permissions/writeText-granted.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/text-write-read/async-write-read.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/text-write-read/async-write-readText.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/text-write-read/async-writeText-read.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/text-write-read/async-writeText-readText.https-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-overscroll-behavior/overscroll-behavior-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/input/mouse-wheel-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/input/snap-area-overflow-boundary-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/selection-target-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/snap-at-user-scroll-end-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/scroll-preserve-3d-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-mousewheel-event-listener-on-body-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-mousewheel-event-listener-on-div-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-mousewheel-event-listener-on-document-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-mousewheel-event-listener-on-root-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-mousewheel-event-listener-on-window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-wheel-event-listener-on-body-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-wheel-event-listener-on-div-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-wheel-event-listener-on-document-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-wheel-event-listener-on-root-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-wheel-event-listener-on-window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-mousewheel-event-listener-on-body-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-mousewheel-event-listener-on-div-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-mousewheel-event-listener-on-document-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-mousewheel-event-listener-on-root-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-mousewheel-event-listener-on-window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-wheel-event-listener-on-body-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-wheel-event-listener-on-div-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-wheel-event-listener-on-document-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-wheel-event-listener-on-root-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-wheel-event-listener-on-window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/iframe-chains-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-options.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-button-element/active-onblur-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/checkable-active-onblur-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-label-element/proxy-modifier-click-to-associated-element.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-canceling-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-node-is-uneditable-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/pointerevents/compat/pointerevent_mouseevent_key_pressed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-keyboard-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js
    M LayoutTests/imported/w3c/web-platform-tests/shadow-dom/accesskey.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/uievents/order-of-events/focus-events/focus-management-expectations-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/uievents/order-of-events/mouse-events/wheel-basic-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/uievents/order-of-events/mouse-events/wheel-scrolling-expected.txt

  Log Message:
  -----------
  Refactor testdriver-vendor.js to make better use of async/await and promises
https://bugs.webkit.org/show_bug.cgi?id=248248
rdar://102613798

Make testdriver-vendor.js a bit more ES idiomatic, plus fix some incorrect
error handling with promises.

Also provides slightly better error messages.

Reviewed by Tim Nguyen.

* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-custom-formats-write-read.tentative.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-html-script-removal.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-navigator-clipboard-read-resource-load.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-navigator-clipboard-read-sanitize.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-promise-write-blobs-read-blobs.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-svg-script-removal.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-unsanitized-html-formats-write-read.tentative.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-unsanitized-plaintext-formats-write-read.tentative.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-write-blobs-read-blobs.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-write-html-read-html.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-write-image-read-image.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/async-write-svg-read-svg.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/detached-iframe/read-on-detaching-iframe.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/detached-iframe/write-on-detaching-iframe.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/detached-iframe/write-read-on-detached-iframe.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/detached-iframe/writeText-readText-on-detached-iframe.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/feature-policy/clipboard-write/clipboard-write-disabled-by-feature-policy.tentative.https.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/feature-policy/clipboard-write/clipboard-write-enabled-by-feature-policy.tentative.https.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/feature-policy/clipboard-write/clipboard-write-enabled-on-self-origin-by-feature-policy.tentative.https.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/permissions/readText-denied.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/permissions/readText-granted.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/permissions/writeText-denied.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/permissions/writeText-granted.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/text-write-read/async-write-read.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/text-write-read/async-write-readText.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/text-write-read/async-writeText-read.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/clipboard-apis/text-write-read/async-writeText-readText.https-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-overscroll-behavior/overscroll-behavior-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/input/mouse-wheel-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/input/snap-area-overflow-boundary-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/selection-target-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-snap/snap-at-user-scroll-end-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/scroll-preserve-3d-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-mousewheel-event-listener-on-body-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-mousewheel-event-listener-on-div-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-mousewheel-event-listener-on-document-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-mousewheel-event-listener-on-root-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-mousewheel-event-listener-on-window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-wheel-event-listener-on-body-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-wheel-event-listener-on-div-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-wheel-event-listener-on-document-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-wheel-event-listener-on-root-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/non-passive-wheel-event-listener-on-window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-mousewheel-event-listener-on-body-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-mousewheel-event-listener-on-div-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-mousewheel-event-listener-on-document-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-mousewheel-event-listener-on-root-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-mousewheel-event-listener-on-window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-wheel-event-listener-on-body-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-wheel-event-listener-on-div-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-wheel-event-listener-on-document-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-wheel-event-listener-on-root-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-wheel-event-listener-on-window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/dom/events/scrolling/iframe-chains-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/element-request-fullscreen-options.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-button-element/active-onblur-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/checkable-active-onblur-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-label-element/proxy-modifier-click-to-associated-element.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-canceling-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-node-is-uneditable-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/pointerevents/compat/pointerevent_mouseevent_key_pressed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-keyboard-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js:
(pause):
(async dispatchMouseActions):
(async dispatchTouchActions):
(async if):
(window.test_driver_internal.send_keys):
(window.test_driver_internal.click):
(async let):
(window.test_driver_internal.action_sequence):
(async switch):
(window.test_driver_internal.set_permission):
(window.test_driver_internal.delete_all_cookies): Deleted.
(window.test_driver_internal.generate_test_report): Deleted.
* LayoutTests/imported/w3c/web-platform-tests/shadow-dom/accesskey.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/uievents/order-of-events/focus-events/focus-management-expectations-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/uievents/order-of-events/mouse-events/wheel-basic-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/uievents/order-of-events/mouse-events/wheel-scrolling-expected.txt:

Canonical link: https://commits.webkit.org/257030@main