[webkit-changes] [WebKit/WebKit] a8c7d4: [WebIDL] Hoist protectedThis reference in JSEventL...

EWS noreply at github.com
Fri Nov 25 15:16:33 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a8c7d4f465b1b468a16c8e256645ae5db2bcb22e
      https://github.com/WebKit/WebKit/commit/a8c7d4f465b1b468a16c8e256645ae5db2bcb22e
  Author: Alexey Shvayka <ashvayka at apple.com>
  Date:   2022-11-25 (Fri, 25 Nov 2022)

  Changed paths:
    M Source/WebCore/bindings/js/JSEventListener.cpp

  Log Message:
  -----------
  [WebIDL] Hoist protectedThis reference in JSEventListener::handleEvent()
https://bugs.webkit.org/show_bug.cgi?id=248328

Reviewed by Yusuke Suzuki.

While this change is non-observable since the only caller of handleEvent(),
innerInvokeEventListeners(), keeps it as RefPtr, theoretically both getCallData() and
jsFunction->get() may remove currently running event listener and cause its destruction.

* Source/WebCore/bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):

Canonical link: https://commits.webkit.org/257027@main




More information about the webkit-changes mailing list