[webkit-changes] [WebKit/WebKit] 108766: [LFC][IFC] Add initial text-combine support for IFC
Alan Baradlay
noreply at github.com
Fri Nov 25 10:54:03 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 108766da79e106812187e387ed2e0b34a7d3990e
https://github.com/WebKit/WebKit/commit/108766da79e106812187e387ed2e0b34a7d3990e
Author: Alan Baradlay <zalan at apple.com>
Date: 2022-11-25 (Fri, 25 Nov 2022)
Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp
M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp
M Source/WebCore/layout/layouttree/LayoutInlineTextBox.cpp
M Source/WebCore/layout/layouttree/LayoutInlineTextBox.h
M Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp
M Source/WebCore/layout/layouttree/LayoutTreeBuilder.h
M Source/WebCore/rendering/RenderBlockFlow.cpp
Log Message:
-----------
[LFC][IFC] Add initial text-combine support for IFC
https://bugs.webkit.org/show_bug.cgi?id=248344
Reviewed by Antti Koivisto.
This patch enables IFC to layout and render combined text.
* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::InlineItemsBuilder::handleTextContent): Combined text is considered as one entity.
* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::TextUtil::width): rotated (upright) text's width is really just the height of the font.
* Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::BoxTree::createLayoutBox): For some reason the text() is empty for the combined content. Need to consult orignalText().
* Source/WebCore/layout/layouttree/LayoutInlineTextBox.cpp:
(WebCore::Layout::InlineTextBox::InlineTextBox):
* Source/WebCore/layout/layouttree/LayoutInlineTextBox.h:
(WebCore::Layout::InlineTextBox::isCombined const):
* Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createTextBox):
(WebCore::Layout::TreeBuilder::createLayoutBox):
* Source/WebCore/layout/layouttree/LayoutTreeBuilder.h:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutModernLines):
Canonical link: https://commits.webkit.org/257025@main
More information about the webkit-changes
mailing list