[webkit-changes] [WebKit/WebKit] f4b30f: [GTK] UI process crash when opening video settings

Carlos Garcia Campos noreply at github.com
Fri Nov 25 06:30:31 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f4b30ff111b45df522f76483d9e7b6ddd0775f78
      https://github.com/WebKit/WebKit/commit/f4b30ff111b45df522f76483d9e7b6ddd0775f78
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2022-11-25 (Fri, 25 Nov 2022)

  Changed paths:
    M Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp
    M Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.h
    M Source/WebKit/WebProcess/InjectedBundle/API/APIInjectedBundlePageContextMenuClient.h
    M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp
    M Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp
    M Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h
    M Source/WebKit/WebProcess/WebPage/WebContextMenu.cpp

  Log Message:
  -----------
  [GTK] UI process crash when opening video settings
https://bugs.webkit.org/show_bug.cgi?id=247089

Reviewed by Michael Catanzaro.

Do no emit the context-menus signals for video settings popup menu.

* Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::WebContextMenuProxyGtk::show):
* Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.h:
* Source/WebKit/WebProcess/InjectedBundle/API/APIInjectedBundlePageContextMenuClient.h:
(API::InjectedBundle::PageContextMenuClient::getCustomMenuFromDefaultItems):
* Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
* Source/WebKit/WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::menuItemsWithUserData const):

Canonical link: https://commits.webkit.org/257023@main




More information about the webkit-changes mailing list