[webkit-changes] [WebKit/WebKit] 3ac7a6: Remove WebPage::performDefaultBehaviorForKeyEvent

Fujii Hironori noreply at github.com
Fri Nov 25 02:32:39 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3ac7a6666750df1beca89df257638d114e13871c
      https://github.com/WebKit/WebKit/commit/3ac7a6666750df1beca89df257638d114e13871c
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2022-11-25 (Fri, 25 Nov 2022)

  Changed paths:
    M Source/WebCore/page/EventHandler.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp
    M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
    M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm
    M Source/WebKit/WebProcess/WebPage/playstation/WebPagePlayStation.cpp
    M Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp
    M Source/WebKit/WebProcess/WebPage/wpe/WebPageWPE.cpp

  Log Message:
  -----------
  Remove WebPage::performDefaultBehaviorForKeyEvent
https://bugs.webkit.org/show_bug.cgi?id=248295

Reviewed by Carlos Garcia Campos.

256929 at main (bug#247949) added a code to EventHandler for keyboard
scrolling, and GTK and WPE ports swiched to use it. WinCairo was the
last port using WebPage::performDefaultBehaviorForKeyEvent for
keyboard scrolling. Changed WinCairo to use EventHandler's keyboard
scrolling and removed performDefaultBehaviorForKeyEvent.

* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::defaultPageUpDownEventHandler):
(WebCore::EventHandler::defaultHomeEndEventHandler):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::keyEvent):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent): Deleted.
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent): Deleted.
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent): Deleted.
* Source/WebKit/WebProcess/WebPage/playstation/WebPagePlayStation.cpp:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent): Deleted.
* Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent): Deleted.
* Source/WebKit/WebProcess/WebPage/wpe/WebPageWPE.cpp:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent): Deleted.

Canonical link: https://commits.webkit.org/257015@main




More information about the webkit-changes mailing list