[webkit-changes] [WebKit/WebKit] cb92b7: RenderListBox::setScrollTop should allow out-of-ra...

Tim Nguyen noreply at github.com
Fri Nov 25 01:35:37 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cb92b7a07300a8d1e890190ee82ad00de879c2d6
      https://github.com/WebKit/WebKit/commit/cb92b7a07300a8d1e890190ee82ad00de879c2d6
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2022-11-25 (Fri, 25 Nov 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-scrolling.optional-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-size-scrolling-and-sizing.optional-expected.txt
    M LayoutTests/platform/gtk/TestExpectations
    M Source/WebCore/rendering/RenderListBox.cpp

  Log Message:
  -----------
  RenderListBox::setScrollTop should allow out-of-range values but clamp them
https://bugs.webkit.org/show_bug.cgi?id=248327
rdar://102656180

Reviewed by Cameron McCormack.

The CSSOM View spec allows out-of-range values when scrolling, but it requires clamping:
https://w3c.github.io/csswg-drafts/cssom-view/#scroll-an-element

* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-scrolling.optional-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-size-scrolling-and-sizing.optional-expected.txt:
* LayoutTests/platform/gtk/TestExpectations:
* Source/WebCore/rendering/RenderListBox.cpp:
(WebCore::RenderListBox::setScrollTop):

Canonical link: https://commits.webkit.org/257012@main




More information about the webkit-changes mailing list