[webkit-changes] [WebKit/WebKit] 13ee07: Wrong overflow behavior for input fields containin...

Tim Nguyen noreply at github.com
Thu Nov 24 22:38:01 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 13ee07bc7a8e703c96573e18cdf6527c40c593c1
      https://github.com/WebKit/WebKit/commit/13ee07bc7a8e703c96573e18cdf6527c40c593c1
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/number-input-vertical-overflow-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/number-input-vertical-overflow-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/number-input-vertical-overflow.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/text-input-vertical-overflow-no-scroll-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/text-input-vertical-overflow-no-scroll.html
    M Source/WebCore/html/shadow/TextControlInnerElements.cpp

  Log Message:
  -----------
  Wrong overflow behavior for input fields containing ::-webkit-textfield-decoration-container in vertical writing-mode
https://bugs.webkit.org/show_bug.cgi?id=248321
rdar://102652144

Reviewed by Cameron McCormack.

min-width: 0; is set to avoid the inner <div> (which has flex-grow: 1) from growing. We need the equivalent in vertical writing mode.

* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/number-input-vertical-overflow-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/number-input-vertical-overflow-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/number-input-vertical-overflow.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/text-input-vertical-overflow-no-scroll-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/text-input-vertical-overflow-no-scroll.html: Added.
* Source/WebCore/html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::resolveCustomStyle):

Canonical link: https://commits.webkit.org/257008@main




More information about the webkit-changes mailing list