[webkit-changes] [WebKit/WebKit] 7275c7: Slider thumb is wrongly placed in vertical writing...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7275c7c8b394ea3e97330b45887428e5331f8414
      https://github.com/WebKit/WebKit/commit/7275c7c8b394ea3e97330b45887428e5331f8414
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-painting-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-vertical-ltr-painting-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-vertical-ltr-painting.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-vertical-rtl-painting-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-vertical-rtl-painting.html
    M Source/WebCore/html/shadow/SliderThumbElement.cpp

  Log Message:
  -----------
  Slider thumb is wrongly placed in vertical writing-mode + RTL
https://bugs.webkit.org/show_bug.cgi?id=248320
rdar://102652014

Reviewed by Cameron McCormack.

thumb->setLocation() uses logical coordinates, so we can't share the same path with appearance: slider-vertical, otherwise we
end up placing the thumb outside of the track.

Add reftests that check that we don't paint anything outside the bounds of the input.

* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-painting-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-vertical-ltr-painting-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-vertical-ltr-painting.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-vertical-rtl-painting-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/range-input-vertical-rtl-painting.html: Added.
* Source/WebCore/html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderContainer::layout):

Canonical link: https://commits.webkit.org/257002@main