[webkit-changes] [WebKit/WebKit] d4236a: [Filters] FilterEffect::calculatePrimitiveSubregio...

Said Abou-Hallawa noreply at github.com
Wed Nov 23 20:31:58 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d4236a4ea1de855429c44f541a7a7c6ac74aeeb1
      https://github.com/WebKit/WebKit/commit/d4236a4ea1de855429c44f541a7a7c6ac74aeeb1
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2022-11-23 (Wed, 23 Nov 2022)

  Changed paths:
    M Source/WebCore/platform/graphics/filters/FEComposite.cpp
    M Source/WebCore/platform/graphics/filters/FEComposite.h
    M Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp
    M Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h
    M Source/WebCore/platform/graphics/filters/FEDisplacementMap.cpp
    M Source/WebCore/platform/graphics/filters/FEDisplacementMap.h
    M Source/WebCore/platform/graphics/filters/FEDropShadow.cpp
    M Source/WebCore/platform/graphics/filters/FEDropShadow.h
    M Source/WebCore/platform/graphics/filters/FEFlood.cpp
    M Source/WebCore/platform/graphics/filters/FEFlood.h
    M Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp
    M Source/WebCore/platform/graphics/filters/FEGaussianBlur.h
    M Source/WebCore/platform/graphics/filters/FEImage.cpp
    M Source/WebCore/platform/graphics/filters/FEImage.h
    M Source/WebCore/platform/graphics/filters/FELighting.cpp
    M Source/WebCore/platform/graphics/filters/FELighting.h
    M Source/WebCore/platform/graphics/filters/FEMorphology.cpp
    M Source/WebCore/platform/graphics/filters/FEMorphology.h
    M Source/WebCore/platform/graphics/filters/FEOffset.cpp
    M Source/WebCore/platform/graphics/filters/FEOffset.h
    M Source/WebCore/platform/graphics/filters/FETile.cpp
    M Source/WebCore/platform/graphics/filters/FETile.h
    M Source/WebCore/platform/graphics/filters/FETurbulence.cpp
    M Source/WebCore/platform/graphics/filters/FETurbulence.h
    M Source/WebCore/platform/graphics/filters/FilterEffect.cpp
    M Source/WebCore/platform/graphics/filters/FilterEffect.h

  Log Message:
  -----------
  [Filters] FilterEffect::calculatePrimitiveSubregion() and calculateImageRect() should take a span of the input image rects
https://bugs.webkit.org/show_bug.cgi?id=248181
rdar://102586592

Reviewed by Cameron McCormack.

Instead of passing a FilterImageVector to these functions we should pass a
Vector<FloatRect> since they care about the FilterImage::imageRect() only.

This work is towards supporting CoreGraphics filters since no FilterImage will be
used while applying the FilterEffects.

* Source/WebCore/platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::calculateImageRect const):
* Source/WebCore/platform/graphics/filters/FEComposite.h:
* Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::calculateImageRect const):
* Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h:
* Source/WebCore/platform/graphics/filters/FEDisplacementMap.cpp:
(WebCore::FEDisplacementMap::calculateImageRect const):
* Source/WebCore/platform/graphics/filters/FEDisplacementMap.h:
* Source/WebCore/platform/graphics/filters/FEDropShadow.cpp:
(WebCore::FEDropShadow::calculateImageRect const):
* Source/WebCore/platform/graphics/filters/FEDropShadow.h:
* Source/WebCore/platform/graphics/filters/FEFlood.cpp:
(WebCore::FEFlood::calculateImageRect const):
* Source/WebCore/platform/graphics/filters/FEFlood.h:
* Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::calculateImageRect const):
* Source/WebCore/platform/graphics/filters/FEGaussianBlur.h:
* Source/WebCore/platform/graphics/filters/FEImage.cpp:
(WebCore::FEImage::calculateImageRect const):
* Source/WebCore/platform/graphics/filters/FEImage.h:
* Source/WebCore/platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::calculateImageRect const):
* Source/WebCore/platform/graphics/filters/FELighting.h:
* Source/WebCore/platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::calculateImageRect const):
* Source/WebCore/platform/graphics/filters/FEMorphology.h:
* Source/WebCore/platform/graphics/filters/FEOffset.cpp:
(WebCore::FEOffset::calculateImageRect const):
* Source/WebCore/platform/graphics/filters/FEOffset.h:
* Source/WebCore/platform/graphics/filters/FETile.cpp:
(WebCore::FETile::calculateImageRect const):
* Source/WebCore/platform/graphics/filters/FETile.h:
* Source/WebCore/platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::calculateImageRect const):
* Source/WebCore/platform/graphics/filters/FETurbulence.h:
* Source/WebCore/platform/graphics/filters/FilterEffect.cpp:
(WebCore::inputPrimitiveSubregions):
(WebCore::FilterEffect::calculatePrimitiveSubregion const):
(WebCore::inputImageRects):
(WebCore::FilterEffect::calculateImageRect const):
(WebCore::FilterEffect::apply):
* Source/WebCore/platform/graphics/filters/FilterEffect.h:

Canonical link: https://commits.webkit.org/256983@main




More information about the webkit-changes mailing list