[webkit-changes] [WebKit/WebKit] d2dc5c: [WebXR] Disarm GCGLOwned object destructors when G...

[Dan Glastonbury]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d2dc5ce72fbec3933f37ca2c8be868dfab98e28c
      https://github.com/WebKit/WebKit/commit/d2dc5ce72fbec3933f37ca2c8be868dfab98e28c
  Author: Dan Glastonbury <djg at apple.com>
  Date:   2022-11-23 (Wed, 23 Nov 2022)

  Changed paths:
    M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp
    M Source/WebCore/platform/graphics/GraphicsContextGL.h

  Log Message:
  -----------
  [WebXR] Disarm GCGLOwned object destructors when GraphicsContextGL is NULL
https://bugs.webkit.org/show_bug.cgi?id=248264
rdar://102173321

Reviewed by Simon Fraser.

It's possible to destroy the underlying GraphicsContextGL before
WebXROpaqueFramebuffer's destructor runs. For example, when creating too WebGL
contexts, the context associated with a WebXROpaqueFramebuffer will be lost.

The GCGLOwned objects exist to catch when the user forgets to clean up. In this
case, where the GraphicsContextGL is NULL at destruction time, there's nothing
to do but reset the GCGLOwned objects, preventing their destructors from
asserting in debug builds.

Canonical link: https://commits.webkit.org/256981@main