[webkit-changes] [WebKit/WebKit] 99cf25: Enable <textarea> in vertical writing mode
Tim Nguyen
noreply at github.com
Wed Nov 23 10:45:44 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 99cf25ddd405c557255c9ae6e865e7b922f8b145
https://github.com/WebKit/WebKit/commit/99cf25ddd405c557255c9ae6e865e7b922f8b145
Author: Tim Nguyen <ntim at apple.com>
Date: 2022-11-23 (Wed, 23 Nov 2022)
Changed paths:
A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/form-controls-slr.png
A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/form-controls-srl.png
A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/form-controls-vlr.png
A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/vertical-form.png
A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/w3c-import.log
A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-horizontal.optional-expected-mismatch.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-horizontal.optional.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-vlr.optional-expected-mismatch.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-vlr.optional.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-vrl.optional-expected-mismatch.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-vrl.optional.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-horizontal.optional-expected-mismatch.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-horizontal.optional.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-vlr.optional-expected-mismatch.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-vlr.optional.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-vrl.optional-expected-mismatch.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-vrl.optional.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-rows-cols-sizing-expected.txt
A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-rows-cols-sizing.html
M LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/w3c-import.log
R LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/form-controls-slr.png
R LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/form-controls-srl.png
R LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/form-controls-vlr.png
R LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/vertical-form.png
M LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/w3c-import.log
M Source/WebCore/css/horizontalFormControls.css
M Source/WebCore/css/html.css
Log Message:
-----------
Enable <textarea> in vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=248260
rdar://102620075
Reviewed by Aditya Keerthi.
It already works properly in vertical writing mode for the most part. Enable it behind the VerticalFormControlsEnabled setting.
Upstream revision for WPT: https://github.com/web-platform-tests/wpt/commit/c758b0d0864c879ffe505c66ba6cf9345db0c665
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/form-controls-slr.png: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/form-controls-slr.png.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/form-controls-srl.png: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/form-controls-srl.png.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/form-controls-vlr.png: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/form-controls-vlr.png.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/vertical-form.png: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/vertical-form.png.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/manual/support/w3c-import.log: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-horizontal.optional-expected-mismatch.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-horizontal.optional.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-vlr.optional-expected-mismatch.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-vlr.optional.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-vrl.optional-expected-mismatch.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-native-vrl.optional.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-horizontal.optional-expected-mismatch.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-horizontal.optional.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-vlr.optional-expected-mismatch.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-vlr.optional.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-vrl.optional-expected-mismatch.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-appearance-none-vrl.optional.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-rows-cols-sizing-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/textarea-rows-cols-sizing.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/w3c-import.log:
* Source/WebCore/css/horizontalFormControls.css:
(@namespace "http://www.w3.org/1999/xhtml";):
* Source/WebCore/css/html.css:
(input:not([type="color"]), select, button, meter, progress):
(input:not([type="color"]), textarea, select, button, meter, progress): Deleted.
Canonical link: https://commits.webkit.org/256977@main
More information about the webkit-changes
mailing list