[webkit-changes] [WebKit/WebKit] e77c6e: [web-animations] support blending of mismatched fi...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e77c6ec7d3fe383255e32ab058d5844289fabbfb
      https://github.com/WebKit/WebKit/commit/e77c6ec7d3fe383255e32ab058d5844289fabbfb
  Author: Antoine Quint <graouts at apple.com>
  Date:   2022-11-23 (Wed, 23 Nov 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/animation/filter-interpolation-002-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/animation/filter-interpolation-003-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation-expected.txt
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    M Source/WebCore/animation/CSSPropertyBlendingClient.h
    M Source/WebCore/animation/KeyframeEffect.cpp
    M Source/WebCore/animation/KeyframeEffect.h

  Log Message:
  -----------
  [web-animations] support blending of mismatched filter lists
https://bugs.webkit.org/show_bug.cgi?id=248270

Reviewed by Simon Fraser.

We would fail to blend when filter lists mismatch and instead always fall back to the "to" value.

Instead of the matching filter functions on KeyframeEffect, we implement the specification for when
blending is supported in PropertyWrapperFilter::canInterpolate() such that we correctly identify
more discrete cases.

* LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/animation/filter-interpolation-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/animation/filter-interpolation-003-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation-expected.txt:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
* Source/WebCore/animation/CSSPropertyBlendingClient.h:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::setBlendingKeyframes):
(WebCore::KeyframeEffect::checkForMatchingFilterFunctionLists const): Deleted.
(WebCore::KeyframeEffect::checkForMatchingFilterFunctionLists): Deleted.
(WebCore::KeyframeEffect::checkForMatchingBackdropFilterFunctionLists): Deleted.
(WebCore::KeyframeEffect::checkForMatchingColorFilterFunctionLists): Deleted.
* Source/WebCore/animation/KeyframeEffect.h:

Canonical link: https://commits.webkit.org/256975@main