[webkit-changes] [WebKit/WebKit] a4f3bf: [webkitpy] WPT server startup is racy

Philippe Normand noreply at github.com
Tue Nov 22 11:42:12 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a4f3bf81be81c1676af4f63abd87e6ed3d117909
      https://github.com/WebKit/WebKit/commit/a4f3bf81be81c1676af4f63abd87e6ed3d117909
  Author: Philippe Normand <philn at igalia.com>
  Date:   2022-11-22 (Tue, 22 Nov 2022)

  Changed paths:
    M Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py
    M Tools/Scripts/webkitpy/port/base.py

  Log Message:
  -----------
  [webkitpy] WPT server startup is racy
https://bugs.webkit.org/show_bug.cgi?id=248146

Reviewed by Darin Adler.

Wait until a 5 seconds timeout happens or the HTTP server has actually finally started before
running any test, otherwise one or a few of the first tests would fail to connect to the HTTP server.

* Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
(WebPlatformTestServer.first_port):
* Tools/Scripts/webkitpy/port/base.py:
(Port.start_web_platform_test_server):

Canonical link: https://commits.webkit.org/256945@main




More information about the webkit-changes mailing list