[webkit-changes] [WebKit/WebKit] 5c1375: [GTK] Deprecate event parameter of WebKitWebView::...

Carlos Garcia Campos noreply at github.com
Tue Nov 22 01:12:36 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5c1375bc471a88183938f25ee0d1df75915f4c77
      https://github.com/WebKit/WebKit/commit/5c1375bc471a88183938f25ee0d1df75915f4c77
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2022-11-22 (Tue, 22 Nov 2022)

  Changed paths:
    M Source/WebKit/UIProcess/API/glib/WebKitOptionMenu.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitOptionMenu.h.in
    M Source/WebKit/UIProcess/API/glib/WebKitOptionMenuPrivate.h
    M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in
    M Source/WebKit/UIProcess/API/glib/WebKitWebViewPrivate.h
    M Source/WebKit/UIProcess/API/gtk/WebKitPopupMenu.cpp
    M Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp
    M Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk3.cpp
    M Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk4.cpp
    M Tools/TestWebKitAPI/Tests/WebKitGLib/TestOptionMenu.cpp

  Log Message:
  -----------
  [GTK] Deprecate event parameter of WebKitWebView::show-option-menu signal
https://bugs.webkit.org/show_bug.cgi?id=248169

Reviewed by Michael Catanzaro.

And add webkit_option_menu_get_event().

* Source/WebKit/UIProcess/API/glib/WebKitOptionMenu.cpp:
(webkitOptionMenuSetEvent):
(webkit_option_menu_get_event):
* Source/WebKit/UIProcess/API/glib/WebKitOptionMenu.h.in:
* Source/WebKit/UIProcess/API/glib/WebKitOptionMenuPrivate.h:
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewPopulateContextMenu):
(webkitWebViewShowOptionMenu):
* Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in:
* Source/WebKit/UIProcess/API/glib/WebKitWebViewPrivate.h:
* Source/WebKit/UIProcess/API/gtk/WebKitPopupMenu.cpp:
(WebKit::WebKitPopupMenu::showPopupMenu):
* Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp:
(webkit_web_view_get_background_color):
(createShowOptionMenuSignal): Deleted.
* Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk3.cpp:
(createShowOptionMenuSignal):
* Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk4.cpp:
(createShowOptionMenuSignal):
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestOptionMenu.cpp:
(OptionMenuTest::showOptionMenuCallback):
(testOptionMenuSelect):
(beforeAll):

Canonical link: https://commits.webkit.org/256927@main




More information about the webkit-changes mailing list