[webkit-changes] [WebKit/WebKit] 26a4b6: On Ventura, exclusively use GameController.framewo...

Brady Eidson noreply at github.com
Mon Nov 21 15:34:24 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 26a4b6d1625f7178f48c3cd34382c2e6bae67903
      https://github.com/WebKit/WebKit/commit/26a4b6d1625f7178f48c3cd34382c2e6bae67903
  Author: Brady Eidson <beidson at apple.com>
  Date:   2022-11-21 (Mon, 21 Nov 2022)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebCore/Modules/gamepad/GamepadManager.cpp
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm
    M Source/WebCore/platform/gamepad/cocoa/GameControllerSoftLink.mm
    M Source/WebKit/UIProcess/Gamepad/cocoa/UIGamepadProviderCocoa.mm
    M Tools/TestWebKitAPI/Tests/mac/HIDGamepads.mm

  Log Message:
  -----------
  On Ventura, exclusively use GameController.framework for gamepads (disable WebKit's IOHID code path)
https://bugs.webkit.org/show_bug.cgi?id=248136
rdar://102264246

Reviewed by Darin Adler.

On Ventura, GameController framework supports every controller we had interest in supporting
via our custom IOHID code.

So let's *only* use the GameController framework code path on Ventura. The support will be superior!

Also fixes some API tests on Ventura, as Ventura also introduced some race conditions between
the IOHID and GameController code paths.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/Modules/gamepad/GamepadManager.cpp:
(WebCore::GamepadManager::makeGamepadVisible):
(WebCore::GamepadManager::registerNavigator):
(WebCore::GamepadManager::unregisterNavigator):
(WebCore::GamepadManager::registerDOMWindow):
(WebCore::GamepadManager::unregisterDOMWindow):
(WebCore::GamepadManager::maybeStartMonitoringGamepads):
(WebCore::GamepadManager::maybeStopMonitoringGamepads):
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm:
(WebCore::disableDefaultSystemAction):
* Source/WebCore/platform/gamepad/cocoa/GameControllerSoftLink.mm:
* Source/WebKit/UIProcess/Gamepad/cocoa/UIGamepadProviderCocoa.mm:
* Tools/TestWebKitAPI/Tests/mac/HIDGamepads.mm:

Canonical link: https://commits.webkit.org/256918@main




More information about the webkit-changes mailing list