[webkit-changes] [WebKit/WebKit] 917f78: ASSERTION FAILED: !mode.contains(IsFixed)

Rob Buis noreply at github.com
Mon Nov 21 08:26:04 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 917f78d471e1e92751fdd72779f25007ccde0b8f
      https://github.com/WebKit/WebKit/commit/917f78d471e1e92751fdd72779f25007ccde0b8f
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2022-11-21 (Mon, 21 Nov 2022)

  Changed paths:
    A LayoutTests/svg/custom/position-fixed-expected.html
    A LayoutTests/svg/custom/position-fixed-expected.svg
    A LayoutTests/svg/custom/position-fixed.html
    A LayoutTests/svg/custom/position-fixed.svg
    M Source/WebCore/rendering/svg/LegacyRenderSVGRoot.cpp

  Log Message:
  -----------
  ASSERTION FAILED: !mode.contains(IsFixed)
https://bugs.webkit.org/show_bug.cgi?id=244596

Reviewed by Nikolas Zimmermann.

These ASSERTs are really old and maybe correct when introduced,
but postion: fixed is allowed on outermost svg elements, so
remove them.

* LayoutTests/svg/custom/position-fixed-expected.html: Added.
* LayoutTests/svg/custom/position-fixed-expected.svg: Added.
* LayoutTests/svg/custom/position-fixed.html: Added.
* LayoutTests/svg/custom/position-fixed.svg: Added.
* Source/WebCore/rendering/svg/LegacyRenderSVGRoot.cpp:
(WebCore::LegacyRenderSVGRoot::mapLocalToContainer const):

Canonical link: https://commits.webkit.org/256907@main




More information about the webkit-changes mailing list