[webkit-changes] [WebKit/WebKit] 16b100: [IFC][Line clamp] Line clamp may produce empty IFCs
Alan Baradlay
noreply at github.com
Mon Nov 21 06:37:52 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 16b10061f0fd7608a1f3d4711e1f937ed1f6a3db
https://github.com/WebKit/WebKit/commit/16b10061f0fd7608a1f3d4711e1f937ed1f6a3db
Author: Alan Baradlay <zalan at apple.com>
Date: 2022-11-21 (Mon, 21 Nov 2022)
Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp
M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
Log Message:
-----------
[IFC][Line clamp] Line clamp may produce empty IFCs
https://bugs.webkit.org/show_bug.cgi?id=248158
Reviewed by Antti Koivisto.
When we run out of the visible lines for line-clamp, sibling IFCs start producing empty content.
However BFC cannot not call into IFC because we still need to produce some geometry (albeit not correct) for content with DOM nodes.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::lineLayout):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::InlineFormattingGeometry::staticPositionForOutOfFlowInlineLevelBox const):
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::computeIsFirstIsLastBoxForInlineContent):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::constructContent):
Canonical link: https://commits.webkit.org/256905@main
More information about the webkit-changes
mailing list