[webkit-changes] [WebKit/WebKit] 2bd70a: [IFC][Line clamp] "-webkit-line-clamp" and "text-o...

Alan Baradlay noreply at github.com
Sun Nov 20 10:25:06 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2bd70adbbcc7f89fa5eb5cd6d9e906a984e949c4
      https://github.com/WebKit/WebKit/commit/2bd70adbbcc7f89fa5eb5cd6d9e906a984e949c4
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2022-11-20 (Sun, 20 Nov 2022)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/block/BlockLayoutState.h
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h

  Log Message:
  -----------
  [IFC][Line clamp] "-webkit-line-clamp" and "text-overflow: ellipsis" both truncate overflow content in inline direction
https://bugs.webkit.org/show_bug.cgi?id=248120

Reviewed by Antti Koivisto.

Move "we need to truncate trailing content" logic out of LineBuilder to InlineFormattingContext and
consult with both "text-overflow" and "-webkit-line-clamp".

* Source/WebCore/layout/formattingContexts/block/BlockLayoutState.h:
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::shouldTruncateOverflow):
(WebCore::Layout::InlineFormattingContext::lineLayout):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::computedIntrinsicWidth):
(WebCore::Layout::LineBuilder::close):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:

Canonical link: https://commits.webkit.org/256890@main




More information about the webkit-changes mailing list