[webkit-changes] [WebKit/WebKit] 1d5e1b: [JSC] SymbolTableRareData should be set after stor...

Yusuke Suzuki noreply at github.com
Fri Nov 18 19:04:02 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1d5e1b435724f80c4d98673e9abcf4faa66ab317
      https://github.com/WebKit/WebKit/commit/1d5e1b435724f80c4d98673e9abcf4faa66ab317
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2022-11-18 (Fri, 18 Nov 2022)

  Changed paths:
    M Source/JavaScriptCore/runtime/SymbolTable.cpp
    M Source/JavaScriptCore/runtime/SymbolTable.h

  Log Message:
  -----------
  [JSC] SymbolTableRareData should be set after store-store-fence
https://bugs.webkit.org/show_bug.cgi?id=248114
rdar://102536737

Reviewed by Mark Lam.

This patch inserts storeStoreFence when setting SymbolTableRareData since
this data structure is read by concurrent GC thread.

* Source/JavaScriptCore/runtime/SymbolTable.cpp:
(JSC::SymbolTable::visitChildrenImpl):
(JSC::SymbolTable::cloneScopePart):
(JSC::SymbolTable::prepareForTypeProfiling):
(JSC::SymbolTable::setRareDataCodeBlock):
(JSC::SymbolTable::ensureRareDataSlow):
* Source/JavaScriptCore/runtime/SymbolTable.h:

Canonical link: https://commits.webkit.org/256868@main




More information about the webkit-changes mailing list