[webkit-changes] [WebKit/WebKit] 93ece5: REGRESSION (250836 at main): [ iOS ] fast/forms/textf...

[Ryan Reno]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 93ece5e17f0a9a8fe3a937f19d79c3a4caedb399
      https://github.com/WebKit/WebKit/commit/93ece5e17f0a9a8fe3a937f19d79c3a4caedb399
  Author: Ryan Reno <rreno at apple.com>
  Date:   2022-11-18 (Fri, 18 Nov 2022)

  Changed paths:
    M LayoutTests/fast/forms/textfield-outline.html
    M LayoutTests/platform/ios-wk2/TestExpectations

  Log Message:
  -----------
  REGRESSION (250836 at main): [ iOS ] fast/forms/textfield-outline.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=241205
rdar://94255807

Reviewed by Simon Fraser.

The test fast/forms/textfield-outline.html became flaky because 250836 at main introduced
asynchronous appearance changes when there is a programmatic selection being set on a frame.
This caused a race condition between the test runner completing and the render tree being
updated with the cursor in the correct scrollX position.

I went part of the way to fixing this test in 252417 at main by switching from synchronous to
asynchronous keydown events in the test. However, the test still had a race condition because
the test runner wasn't being told to wait for all three asynchronous key downs to complete.

This simply puts the testRunner in "asynchronous mode" by calling testRunner.waitUntilDone and
testRunner.notifyDone.

* LayoutTests/fast/forms/textfield-outline.html:
* LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/256856@main