[webkit-changes] [WebKit/WebKit] 559702: [WebIDL] Make maplike<> and setlike<> generated me...

EWS noreply at github.com
Fri Nov 18 09:09:51 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 559702ad5ccdf4dc7db8ddf877b01c6197ca8d7f
      https://github.com/WebKit/WebKit/commit/559702ad5ccdf4dc7db8ddf877b01c6197ca8d7f
  Author: Alexey Shvayka <ashvayka at apple.com>
  Date:   2022-11-18 (Fri, 18 Nov 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-font-loading/idlharness.https-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/idlharness.window-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/idlharness.window.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/idlharness.window.js
    M LayoutTests/imported/w3c/web-platform-tests/dom/idlharness.window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/file-system-access/idlharness.https.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/file-system-access/idlharness.https.any.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/interfaces/css-highlight-api.idl
    M LayoutTests/imported/w3c/web-platform-tests/resources/idlharness.js
    M LayoutTests/imported/w3c/web-platform-tests/streams/idlharness.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/streams/idlharness.any.serviceworker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/streams/idlharness.any.worker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/webaudio/idlharness.https.window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/webrtc/idlharness.https.window-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-font-loading/idlharness.https-expected.txt
    M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
    M Source/WebCore/bindings/scripts/test/JS/JSTestMapLike.cpp
    M Source/WebCore/bindings/scripts/test/JS/JSTestMapLikeWithOverriddenOperations.cpp
    M Source/WebCore/bindings/scripts/test/JS/JSTestReadOnlyMapLike.cpp
    M Source/WebCore/bindings/scripts/test/JS/JSTestReadOnlySetLike.cpp
    M Source/WebCore/bindings/scripts/test/JS/JSTestSetLike.cpp
    M Source/WebCore/bindings/scripts/test/JS/JSTestSetLikeWithOverriddenOperations.cpp

  Log Message:
  -----------
  [WebIDL] Make maplike<> and setlike<> generated methods enumerable
https://bugs.webkit.org/show_bug.cgi?id=245771
<rdar://100798576>

Reviewed by Sam Weinig and Yusuke Suzuki.

This change makes maplike<> and setlike<> generated method enumerable per latest spec change [1],
aligning WebKit with Blink and Gecko.

Since the methods are being tested via wpt/resources/idlharness.js, it was synced along with
a few other changes, causing some expectations to be adjusted.

Also, syncs CSS Custom Highlight API's idlharness.js test to ensure that setlike<> declarations
are tested as well.

[1] https://github.com/whatwg/webidl/pull/1166

* LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/idlharness.window-expected.txt:
HighlightRegistry's maplike<DOMString, Highlight> tests are failing because the interface was renamed in the spec, but not yet in our codebase.

* LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/idlharness.window.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/idlharness.window.js: Sync from upstream, commit 2ecf81b0ea0b6c45035038d8d381c6d2962d2347.
* LayoutTests/imported/w3c/web-platform-tests/interfaces/css-highlight-api.idl: Sync from upstream, commit 11ec24d28e86b8809d7f17833b7306bb5c8401ec.
* LayoutTests/imported/w3c/web-platform-tests/resources/idlharness.js: Sync from upstream, commit 56ec9beaab4ecd393f99d256a2ac2a4e66a09f9c.
* LayoutTests/imported/w3c/web-platform-tests/*-expected.txt: Adjust expectations.
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-font-loading/idlharness.https-expected.txt: Adjust expectations.
* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(AddMapLikeAttributesAndOperationIfNeeded):
(AddSetLikeAttributesAndOperationIfNeeded):
* Source/WebCore/bindings/scripts/test/JS/*: Updated.

Canonical link: https://commits.webkit.org/256838@main




More information about the webkit-changes mailing list