[webkit-changes] [WebKit/WebKit] 8230e6: [Live Range Selection] editing/pasteboard/copy-wit...

Ryosuke Niwa noreply at github.com
Thu Nov 17 23:07:01 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8230e6a4e70d8792cbb3b38d64d5fd0f5f47ff66
      https://github.com/WebKit/WebKit/commit/8230e6a4e70d8792cbb3b38d64d5fd0f5f47ff66
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2022-11-17 (Thu, 17 Nov 2022)

  Changed paths:
    A LayoutTests/editing/pasteboard/copy-with-shadow-tree-crash-live-range-expected.txt
    A LayoutTests/editing/pasteboard/copy-with-shadow-tree-crash-live-range.html
    M Source/WebCore/page/DOMSelection.cpp

  Log Message:
  -----------
  [Live Range Selection] editing/pasteboard/copy-with-shadow-tree-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=248068

Reviewed by Wenson Hsieh.

The bug was caused by DOMSelection::rangeCount returning 0 whenever range crosses shadow boundaries.
Remove this check since DOMSelection shouldn't be considered as empty when there are selections anywhere.

* LayoutTests/editing/pasteboard/copy-with-shadow-tree-crash-live-range-expected.txt: Added.
* LayoutTests/editing/pasteboard/copy-with-shadow-tree-crash-live-range.html: Added.
* Source/WebCore/page/DOMSelection.cpp:
(WebCore::DOMSelection::rangeCount const):

Canonical link: https://commits.webkit.org/256822@main




More information about the webkit-changes mailing list