[webkit-changes] [WebKit/WebKit] 606c22: Clean up LayerProperties a little

Simon Fraser noreply at github.com
Thu Nov 17 17:42:09 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 606c220f2c38d31cecf182702426567e81209415
      https://github.com/WebKit/WebKit/commit/606c220f2c38d31cecf182702426567e81209415
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2022-11-17 (Thu, 17 Nov 2022)

  Changed paths:
    M Source/WebCore/platform/graphics/ca/PlatformCALayer.h
    M Source/WebCore/platform/graphics/ca/TileController.cpp
    M Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.h
    M Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm
    M Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp
    M Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h
    M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h

  Log Message:
  -----------
  Clean up LayerProperties a little
https://bugs.webkit.org/show_bug.cgi?id=248021
rdar://102450702

Reviewed by Tim Horton.

Convert RemoteLayerTreeTransaction::LayerProperties to use C++ initializers.

edgeAntialiasingMask was initialized with a CALayer enum. We only ever set
the values for all edges, so convert this to a bool, and use the CA enum
when we actually touch CALayer.

Order `antialiasesEdges` with the other bools.

* Source/WebCore/platform/graphics/ca/PlatformCALayer.h:
* Source/WebCore/platform/graphics/ca/TileController.cpp:
(WebCore::TileController::createTileLayer):
* Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
* Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayerCocoa::setAntialiasesEdges):
(WebCore::PlatformCALayerCocoa::setEdgeAntialiasingMask): Deleted.
* Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayerWin::setAntialiasesEdges):
(PlatformCALayerWin::setEdgeAntialiasingMask): Deleted.
* Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h:
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode const):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::dumpChangedLayers):
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::setAntialiasesEdges):
(WebKit::PlatformCALayerRemote::setEdgeAntialiasingMask): Deleted.
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:

Canonical link: https://commits.webkit.org/256815@main




More information about the webkit-changes mailing list