[webkit-changes] [WebKit/WebKit] e633ef: [LBSE] Allow to query supplementalTransform() with...

Nikolas Zimmermann noreply at github.com
Thu Nov 17 08:18:15 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e633ef2c414eb2708df4f5b58b19ca72b20dfa0b
      https://github.com/WebKit/WebKit/commit/e633ef2c414eb2708df4f5b58b19ca72b20dfa0b
  Author: Nikolas Zimmermann <nzimmermann at igalia.com>
  Date:   2022-11-17 (Thu, 17 Nov 2022)

  Changed paths:
    M Source/WebCore/svg/SVGAnimateMotionElement.cpp
    M Source/WebCore/svg/SVGElement.h
    M Source/WebCore/svg/SVGGraphicsElement.cpp
    M Source/WebCore/svg/SVGGraphicsElement.h

  Log Message:
  -----------
  [LBSE] Allow to query supplementalTransform() without creation
https://bugs.webkit.org/show_bug.cgi?id=247670

Reviewed by Rob Buis.

There is no way to check for the presence of SMIL supplementalTransform() instances,
since calling that method implicitly creates it. Split it up into another
ensureSupplementalTransform() method, that forces creation and another supplementalTransform()
method that simply returns the object, if present.

Covered by existing tests.

* Source/WebCore/svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::startAnimation):
(WebCore::SVGAnimateMotionElement::stopAnimation):
(WebCore::SVGAnimateMotionElement::calculateAnimatedValue):
(WebCore::SVGAnimateMotionElement::applyResultsToTarget):
* Source/WebCore/svg/SVGElement.h:
(WebCore::SVGElement::ensureSupplementalTransform):
(WebCore::SVGElement::supplementalTransform const):
(WebCore::SVGElement::supplementalTransform): Deleted.
* Source/WebCore/svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::ensureSupplementalTransform):
(WebCore::SVGGraphicsElement::svgAttributeChanged):
(WebCore::SVGGraphicsElement::toClipPath):
(WebCore::SVGGraphicsElement::supplementalTransform): Deleted.
* Source/WebCore/svg/SVGGraphicsElement.h:

Canonical link: https://commits.webkit.org/256786@main




More information about the webkit-changes mailing list