[webkit-changes] [WebKit/WebKit] 47042b: [web-animations] web-animations/interfaces/Keyfram...

Antoine Quint noreply at github.com
Thu Nov 17 06:07:33 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 47042b3dade14b3c2ae99642888fba679ae33995
      https://github.com/WebKit/WebKit/commit/47042b3dade14b3c2ae99642888fba679ae33995
  Author: Antoine Quint <graouts at apple.com>
  Date:   2022-11-17 (Thu, 17 Nov 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/getKeyframes-expected.txt
    M Source/WebCore/animation/KeyframeEffect.cpp

  Log Message:
  -----------
  [web-animations] web-animations/interfaces/KeyframeEffect/getKeyframes.html is a unique failure
https://bugs.webkit.org/show_bug.cgi?id=248028

Reviewed by Antti Koivisto.

In the case of script-originated keyframe effects, calling getKeyframes() simply uses the style strings
as they were provided via the API, so those values have not been parsed yet. However, the ParsedKeyframe
we create the ComputedKeyframe from has those parsed values stored via a MutableStyleProperties member,
so we can just replace the string values with the parsed ones.

* LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/getKeyframes-expected.txt:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::getKeyframes):

Canonical link: https://commits.webkit.org/256781@main




More information about the webkit-changes mailing list