[webkit-changes] [WebKit/WebKit] 10ff50: Fix WebKitTestRunner's jscOption configuration
Yusuke Suzuki
noreply at github.com
Wed Nov 16 21:12:28 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 10ff500020954b792f3f2f25ef2ae0dd2fdde847
https://github.com/WebKit/WebKit/commit/10ff500020954b792f3f2f25ef2ae0dd2fdde847
Author: Yusuke Suzuki <ysuzuki at apple.com>
Date: 2022-11-16 (Wed, 16 Nov 2022)
Changed paths:
M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
M Tools/WebKitTestRunner/TestController.cpp
Log Message:
-----------
Fix WebKitTestRunner's jscOption configuration
https://bugs.webkit.org/show_bug.cgi?id=248006
rdar://102445778
Reviewed by Chris Dumez.
250473 at main removed Reset message to InjectedBundle before starting a test to fix flaky language setting issue.
However, this broke jscOption since the code was expecting that Reset message is sent before running test,
and we were setting jscOption at that timing.
This patch recovers Reset message and instead, we add ResetStage field to the message so that InjectedBundle can
avoid running language setting etc. for ResetStage::BeforeTest case while it sets jscOption for the test.
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessageToPage):
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
Canonical link: https://commits.webkit.org/256767@main
More information about the webkit-changes
mailing list