[webkit-changes] [WebKit/WebKit] b45acc: Address FIXMEs in process-css-properties.py

Sam Weinig noreply at github.com
Wed Nov 16 18:59:22 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b45acc1caf6b1fdfd094f77e80a54833c61cf726
      https://github.com/WebKit/WebKit/commit/b45acc1caf6b1fdfd094f77e80a54833c61cf726
  Author: Sam Weinig <weinig at apple.com>
  Date:   2022-11-16 (Wed, 16 Nov 2022)

  Changed paths:
    M Source/WebCore/css/process-css-properties.py

  Log Message:
  -----------
  Address FIXMEs in process-css-properties.py
https://bugs.webkit.org/show_bug.cgi?id=247861
rdar://102292266

Reviewed by Darin Adler.

Address the FIXMEs I left in process-css-properties.py to make the
transition from the old script easier. This mostly was removal of
unnecessary extra sorting that was done to maintain character for
character parity with the old script.

Additionally, this removes a bunch of unnecessary list allocations
by converting list-comprehension expressions (i.e. [x for x in foo])
into generator-comprehension expressions (i.e. (x for x in foo)) where
materializing the list early was not necessary or useful. This allows
getting rid of a bunch of caching as well, which is nice.

* Source/WebCore/css/process-css-properties.py:

Canonical link: https://commits.webkit.org/256763@main




More information about the webkit-changes mailing list