[webkit-changes] [WebKit/WebKit] 42fd02: [ews] merge-queue fails to find reviewer on GitHub...
Jonathan Bedard
noreply at github.com
Wed Nov 16 14:43:02 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 42fd020fc0c32ab8ef648cacc49fcbe3d2fd1a81
https://github.com/WebKit/WebKit/commit/42fd020fc0c32ab8ef648cacc49fcbe3d2fd1a81
Author: Jonathan Bedard <jbedard at apple.com>
Date: 2022-11-16 (Wed, 16 Nov 2022)
Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[ews] merge-queue fails to find reviewer on GitHub PRs with lots of review activity
https://bugs.webkit.org/show_bug.cgi?id=243548
rdar://98129710
Reviewed by Aakash Jain.
* Tools/CISupport/ews-build/steps.py:
(GitHubMixin):
(GitHubMixin.get_reviewers): Handle pagination when retrieving reviews. Approval
and rejection should override older approval or rejection.
* Tools/CISupport/ews-build/steps_unittest.py:
(TestGitHubMixin):
(TestGitHubMixin.Response): Mock of request's response class.
(TestGitHubMixin.test_no_reviewers):
(TestGitHubMixin.test_single_review):
(TestGitHubMixin.test_multipe_reviews):
(TestGitHubMixin.test_retracted_review):
(TestGitHubMixin.test_pagination):
(TestGitHubMixin.test_reviewers_invalid_response):
(TestGitHubMixin.test_reviewers_error):
Canonical link: https://commits.webkit.org/256752@main
More information about the webkit-changes
mailing list