[webkit-changes] [WebKit/WebKit] 8a344c: Fix debug assertion failure in IndentOutdentComman...

Miguel Salinas noreply at github.com
Wed Nov 16 12:51:06 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a344c3387b2bfe58dc8c8a94b1683187effef2e
      https://github.com/WebKit/WebKit/commit/8a344c3387b2bfe58dc8c8a94b1683187effef2e
  Author: Miguel Salinas <miguel_salinas at apple.com>
  Date:   2022-11-16 (Wed, 16 Nov 2022)

  Changed paths:
    A LayoutTests/editing/execCommand/indent-user-select-all-blockquotes-expected.txt
    A LayoutTests/editing/execCommand/indent-user-select-all-blockquotes.html
    M Source/WebCore/editing/IndentOutdentCommand.cpp

  Log Message:
  -----------
  Fix debug assertion failure in IndentOutdentCommand::indentIntoBlockquote
https://bugs.webkit.org/show_bug.cgi?id=240377
rdar://93236442

Reviewed by Ryosuke Niwa.

When indenting an element into a new uneditable blockquote we end up
replacing the element with an empty blockquote instead of indenting.
This also fails an assert in debug builds.
We should just bail out instead of trying to indent if the blockquote
is not editable.

* LayoutTests/editing/execCommand/indent-user-select-all-blockquotes-expected.txt: Added.
* LayoutTests/editing/execCommand/indent-user-select-all-blockquotes.html: Added.
* Source/WebCore/editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::indentIntoBlockquote):

Canonical link: https://commits.webkit.org/256749@main




More information about the webkit-changes mailing list