[webkit-changes] [WebKit/WebKit] 3fac3f: RemoteAudioDestinationProxy base class is platform...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3fac3faf1d5b167d9fbbd9bf4555c133718f5044
      https://github.com/WebKit/WebKit/commit/3fac3faf1d5b167d9fbbd9bf4555c133718f5044
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2022-11-16 (Wed, 16 Nov 2022)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/Sources.txt
    M Source/WebCore/SourcesCocoa.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/platform/audio/AudioDestination.h
    A Source/WebCore/platform/audio/AudioDestinationResampler.cpp
    A Source/WebCore/platform/audio/AudioDestinationResampler.h
    M Source/WebCore/platform/audio/PushPullFIFO.h
    M Source/WebCore/platform/audio/cocoa/AudioDestinationCocoa.cpp
    M Source/WebCore/platform/audio/cocoa/AudioDestinationCocoa.h
    A Source/WebCore/platform/audio/cocoa/AudioUtilitiesCocoa.cpp
    A Source/WebCore/platform/audio/cocoa/AudioUtilitiesCocoa.h
    M Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp
    M Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.h
    M Source/WebCore/platform/mock/MockAudioDestinationCocoa.cpp
    M Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp
    M Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.h

  Log Message:
  -----------
  RemoteAudioDestinationProxy base class is platform specific
https://bugs.webkit.org/show_bug.cgi?id=247802
rdar://problem/102238646

Reviewed by Eric Carlson.

The ifdefing causes problems when passing the needed information to
RemoteAudioDestinationManager::CreateAudioDestination. Due to this,
the GPUP side instance is created with
CreateAudioDestination+AudioSamplesStorageChanged message, which
causes other problems.

Instead, extract the needed platform-agnostic logic from
AudioDestinationCocoa to AudioDestinationResampler.
Use AudioDestinationResampler as the base-class of
RemoteAudioDestinationProxy, as that is the way the data
is transferred currently.

This is preliminary work to be able to make CARingBuffer
as a platform-agnostic AudioRingBuffer, in order to pass
the ring buffer during the remote audio destination creation.

* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/audio/AudioDestination.h:
(WebCore::AudioDestination::sampleRate const):
(WebCore::AudioDestination::AudioDestination):
* Source/WebCore/platform/audio/PushPullFIFO.h:
* Source/WebCore/platform/audio/cocoa/AudioDestinationCocoa.cpp:
(WebCore::AudioDestinationCocoa::AudioDestinationCocoa):
(WebCore::AudioDestinationCocoa::render):
(WebCore::AudioDestinationCocoa::numberOfOutputChannels const): Deleted.
(WebCore::AudioDestinationCocoa::framesPerBuffer const): Deleted.
(WebCore::AudioDestinationCocoa::start): Deleted.
(WebCore::AudioDestinationCocoa::stop): Deleted.
(WebCore::AudioDestinationCocoa::setIsPlaying): Deleted.
(WebCore::AudioDestinationCocoa::getAudioStreamBasicDescription): Deleted.
(WebCore::assignAudioBuffersToBus): Deleted.
(WebCore::AudioDestinationCocoa::hasEnoughFrames const): Deleted.
(WebCore::AudioDestinationCocoa::renderOnRenderingTheadIfPlaying): Deleted.
(WebCore::AudioDestinationCocoa::renderOnRenderingThead): Deleted.
* Source/WebCore/platform/audio/cocoa/AudioDestinationCocoa.h:
(): Deleted.
* Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.h:
* Source/WebCore/platform/mock/MockAudioDestinationCocoa.cpp:
(WebCore::MockAudioDestinationCocoa::tick):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateScrollingNodeForViewportConstrainedRole):
* Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:
(WebKit::RemoteAudioDestinationProxy::create):
(WebKit::RemoteAudioDestinationProxy::RemoteAudioDestinationProxy):
(WebKit::RemoteAudioDestinationProxy::connection):
(WebKit::RemoteAudioDestinationProxy::startRendering):
(WebKit::RemoteAudioDestinationProxy::stopRendering):
(WebKit::RemoteAudioDestinationProxy::renderQuantum):
* Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.h:

Canonical link: https://commits.webkit.org/256729@main