[webkit-changes] [WebKit/WebKit] da44a7: REGRESSION (Ventura): [ macOS ] 2X TestWebKitAPI.S...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da44a798c8a12288aacb2163909b6e3e859a4401
      https://github.com/WebKit/WebKit/commit/da44a798c8a12288aacb2163909b6e3e859a4401
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2022-11-16 (Wed, 16 Nov 2022)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SOAuthorizationTests.mm

  Log Message:
  -----------
  REGRESSION (Ventura): [ macOS ] 2X TestWebKitAPI.SOAuthorizationRedirect.DismissUIDuringMiniaturization (API-Tests) are constant failures
https://bugs.webkit.org/show_bug.cgi?id=247924
rdar://problem/102343029

Reviewed by Darin Adler.

The test assumed that actions to NSWindows or NSApp reflect synchronously
back to the notifications. This is not the case.

Ensure that the test expects asynchronous operation.

Fix incorrect adoptNS() for notification center observers. The add function is
not a NS creation function, and as such it doesn't return an adoptable ref.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/SOAuthorizationTests.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/256727@main