[webkit-changes] [WebKit/WebKit] e1737d: With UI-side compositing enabled, some reflections...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e1737d40665334ff7f8328ff474e152825cf8888
      https://github.com/WebKit/WebKit/commit/e1737d40665334ff7f8328ff474e152825cf8888
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2022-11-15 (Tue, 15 Nov 2022)

  Changed paths:
    M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
    M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp

  Log Message:
  -----------
  With UI-side compositing enabled, some reflections tests fail
https://bugs.webkit.org/show_bug.cgi?id=247923
rdar://102277328

Reviewed by Cameron McCormack.

`updateCustomAppearance()` is always called on cloned layers. This set the `CustomAppearanceChanged`
bit, which resulted in the UI Process removing the custom appearance, which removes the layer
background color. This would clobber any background color set on "solid color" layer clones.

Other minor code cleanup.

* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::setBackgroundColor):
(WebKit::PlatformCALayerRemote::updateCustomAppearance):

Canonical link: https://commits.webkit.org/256718@main