[webkit-changes] [WebKit/WebKit] ce051f: RemoteAudioDestinationManager::AudioSamplesStorage...

Kimmo Kinnunen noreply at github.com
Tue Nov 15 02:39:58 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ce051f767fb9df5e38db1141446915a2b60cdaf3
      https://github.com/WebKit/WebKit/commit/ce051f767fb9df5e38db1141446915a2b60cdaf3
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2022-11-15 (Tue, 15 Nov 2022)

  Changed paths:
    M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp
    M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.h
    M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.messages.in
    M Source/WebKit/Shared/Cocoa/SharedCARingBuffer.cpp
    M Source/WebKit/Shared/Cocoa/SharedCARingBuffer.h
    M Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp

  Log Message:
  -----------
  RemoteAudioDestinationManager::AudioSamplesStorageChanged sends redundant stream description
https://bugs.webkit.org/show_bug.cgi?id=247733
rdar://problem/102193653

Reviewed by Youenn Fablet.

The stream must be exactly as RemoteAudioDestination audio output unit adaptor needs,
the sender cannot configure anything related to it.

Remove the parameter.

In later patches, the ring buffer can be obtained via the constructor and as such
the added member variable m_numChannelStreams can be removed.

* Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:
(WebKit::RemoteAudioDestinationManager::audioSamplesStorageChanged):
* Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.h:
* Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.messages.in:
* Source/WebKit/Shared/Cocoa/SharedCARingBuffer.cpp:
(WebKit::ConsumerSharedCARingBuffer::map):
* Source/WebKit/Shared/Cocoa/SharedCARingBuffer.h:
* Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:
(WebKit::RemoteAudioDestinationProxy::connection):

Canonical link: https://commits.webkit.org/256687@main




More information about the webkit-changes mailing list