[webkit-changes] [WebKit/WebKit] 2fe8f9: html/semantics/interactive-elements/the-dialog-ele...

Ryosuke Niwa noreply at github.com
Mon Nov 14 14:10:11 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2fe8f95f2038133a86a66f58504f2c7dff5de6f9
      https://github.com/WebKit/WebKit/commit/2fe8f95f2038133a86a66f58504f2c7dff5de6f9
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focus-shadow-expected.txt
    M Source/WebCore/dom/Element.cpp

  Log Message:
  -----------
  html/semantics/interactive-elements/the-dialog-element/dialog-focus-shadow.html fails
https://bugs.webkit.org/show_bug.cgi?id=247910

Reviewed by Tim Nguyen.

The test cases were failing because "autofocus delegate" was invoking "autofocus delegate" in step 1.2. instead of
"getting the focusable area", which then invokes "focus delegate" when the target is a shadow host with focus delegates.

Relevant spec concepts:
https://html.spec.whatwg.org/multipage/interaction.html#autofocus-delegate
https://html.spec.whatwg.org/multipage/interaction.html#focus-delegate
https://html.spec.whatwg.org/multipage/interaction.html#get-the-focusable-area

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focus-shadow-expected.txt:
* Source/WebCore/dom/Element.cpp:
(WebCore::autoFocusDelegate):

Canonical link: https://commits.webkit.org/256672@main




More information about the webkit-changes mailing list