[webkit-changes] [WebKit/WebKit] 2cb930: Revert 255044 at main as it introduces crash in SQLit...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2cb930b2456b9bdd545fa5af440b652a89b59e55
      https://github.com/WebKit/WebKit/commit/2cb930b2456b9bdd545fa5af440b652a89b59e55
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
    M Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.cpp
    M Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.h

  Log Message:
  -----------
  Revert 255044 at main as it introduces crash in SQLiteStorageArea::removeItem
https://bugs.webkit.org/show_bug.cgi?id=247767
rdar://101927216

Reviewed by Ben Nham and Per Arne Vollan.

>From 255044 at main we started to track LocalStorage size manually for quota check instead of setting hard limit on
database file. However, LocalStorage might convert 16-bit string to 8-bit string when reading from database for memory
optimization (246784 at main), and we didn't consider that in computation. This has let to overflow error in
SQLiteStorageArea::removeItem.

* Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.cpp:
(WebKit::SQLiteStorageArea::isEmpty):
(WebKit::SQLiteStorageArea::prepareDatabase):
(WebKit::SQLiteStorageArea::getItem):
(WebKit::SQLiteStorageArea::allItems):
(WebKit::SQLiteStorageArea::setItem):
(WebKit::SQLiteStorageArea::removeItem):
(WebKit::SQLiteStorageArea::clear):
(WebKit::SQLiteStorageArea::getAllItemsFromDatabase): Deleted.
(WebKit::SQLiteStorageArea::initializeCache): Deleted.
* Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.h:

Canonical link: https://commits.webkit.org/256670@main