[webkit-changes] [WebKit/WebKit] 207c35: Keyboard smooth scrolling animation is not disable...

Richard Robinson noreply at github.com
Mon Nov 14 10:55:26 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 207c359c1849663ffceaf90b4d5aae6727eb4230
      https://github.com/WebKit/WebKit/commit/207c359c1849663ffceaf90b4d5aae6727eb4230
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
    M Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml
    M Tools/WebKitTestRunner/TestOptions.cpp

  Log Message:
  -----------
  Keyboard smooth scrolling animation is not disabled when `NSScrollAnimationEnabled` is `false`
https://bugs.webkit.org/show_bug.cgi?id=247822
rdar://101225956

Reviewed by Simon Fraser.

Previously, setting `NSScrollAnimationEnabled` to `false` would disable all
scroll animations. However, enabling keyboard smooth scrolling regressed this
and did not respect this setting any longer.

This PR fixes this by having `EventHandlerDrivenSmoothScrolling` respect the
value of `NSScrollAnimationEnabled` so now scroll animations may once again be
disabled.

* Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:

Canonical link: https://commits.webkit.org/256661@main




More information about the webkit-changes mailing list