[webkit-changes] [WebKit/WebKit] 8f06b8: Rename FormAssociatedElement to FormListedElement

Mon Nov 14 10:16:33 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8f06b8caf972d5cdf4d4f506acd91aae57bab856
      https://github.com/WebKit/WebKit/commit/8f06b8caf972d5cdf4d4f506acd91aae57bab856
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/dom/ContainerNodeAlgorithms.h
    M Source/WebCore/dom/TreeScopeOrderedMap.cpp
    R Source/WebCore/html/FormAssociatedElement.cpp
    R Source/WebCore/html/FormAssociatedElement.h
    M Source/WebCore/html/FormController.cpp
    A Source/WebCore/html/FormListedElement.cpp
    A Source/WebCore/html/FormListedElement.h
    M Source/WebCore/html/FormNamedItem.h
    M Source/WebCore/html/HTMLElement.cpp
    M Source/WebCore/html/HTMLElement.h
    M Source/WebCore/html/HTMLFieldSetElement.h
    M Source/WebCore/html/HTMLFormControlElement.cpp
    M Source/WebCore/html/HTMLFormControlElement.h
    M Source/WebCore/html/HTMLFormControlElementWithState.h
    M Source/WebCore/html/HTMLFormControlsCollection.cpp
    M Source/WebCore/html/HTMLFormControlsCollection.h
    M Source/WebCore/html/HTMLFormElement.cpp
    M Source/WebCore/html/HTMLFormElement.h
    M Source/WebCore/html/HTMLImageElement.cpp
    M Source/WebCore/html/HTMLImageElement.h
    M Source/WebCore/html/HTMLLabelElement.cpp
    M Source/WebCore/html/HTMLObjectElement.cpp
    M Source/WebCore/html/HTMLObjectElement.h
    M Source/WebCore/html/ValidityState.h
    M Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm
    M Source/WebKitLegacy/win/WebFrame.cpp

  Log Message:
  -----------
  Rename FormAssociatedElement to FormListedElement
https://bugs.webkit.org/show_bug.cgi?id=247877

Reviewed by Chris Dumez.

Renamed FormAssociatedElement to FormListedElement, and updated relevant code since it maps to the concept
of the same name in HTML5 specification: https://html.spec.whatwg.org/multipage/forms.html#category-listed

This patch also moves refFormAssociatedElement / derefFormAssociatedElement from FormAssociatedElement
to FormNamedItem, which will be renamed to FormAssociatedElement in a follow up patch.

* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/dom/ContainerNodeAlgorithms.h:

* Source/WebCore/dom/TreeScopeOrderedMap.cpp:
(WebCore::TreeScopeOrderedMap::get const):

* Source/WebCore/html/FormController.cpp:
(WebCore::formSignature):
(WebCore::FormController::restoreControlStateIn):

* Source/WebCore/html/FormListedElement.cpp: Renamed from Source/WebCore/html/FormAssociatedElement.cpp.
(WebCore::FormListedElement::FormListedElement):
(WebCore::FormListedElement::~FormListedElement):
(WebCore::FormListedElement::didMoveToNewDocument):
(WebCore::FormListedElement::insertedIntoAncestor):
(WebCore::FormListedElement::removedFromAncestor):
(WebCore::FormListedElement::findAssociatedForm):
(WebCore::FormListedElement::form const):
(WebCore::FormListedElement::formOwnerRemovedFromTree):
(WebCore::FormListedElement::setForm):
(WebCore::FormListedElement::willChangeForm):
(WebCore::FormListedElement::didChangeForm):
(WebCore::FormListedElement::formWillBeDestroyed):
(WebCore::FormListedElement::resetFormOwner):
(WebCore::FormListedElement::formAttributeChanged):
(WebCore::FormListedElement::customError const):
(WebCore::FormListedElement::hasBadInput const):
(WebCore::FormListedElement::patternMismatch const):
(WebCore::FormListedElement::rangeOverflow const):
(WebCore::FormListedElement::rangeUnderflow const):
(WebCore::FormListedElement::stepMismatch const):
(WebCore::FormListedElement::tooShort const):
(WebCore::FormListedElement::tooLong const):
(WebCore::FormListedElement::typeMismatch const):
(WebCore::FormListedElement::computeValidity const):
(WebCore::FormListedElement::valueMissing const):
(WebCore::FormListedElement::customValidationMessage const):
(WebCore::FormListedElement::validationMessage const):
(WebCore::FormListedElement::setCustomValidity):
(WebCore::FormListedElement::resetFormAttributeTargetObserver):
(WebCore::FormListedElement::formAttributeTargetChanged):
(WebCore::FormListedElement::name const):
(WebCore::FormListedElement::isFormControlElementWithState const):
(WebCore::FormAttributeTargetObserver::FormAttributeTargetObserver):
(WebCore::FormAttributeTargetObserver::idTargetChanged):

* Source/WebCore/html/FormListedElement.h: Renamed from Source/WebCore/html/FormAssociatedElement.h.
(WebCore::FormListedElement::appendFormData):
(WebCore::FormListedElement::badInput const):
(WebCore::FormListedElement::clearForm):

* Source/WebCore/html/FormNamedItem.h:
(WebCore::FormNamedItem::ref): Moved from FormAssociatedElement.
(WebCore::FormNamedItem::deref): Ditto.

* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::asFormListedElement): Renamed from asFormAssociatedElement.
* Source/WebCore/html/HTMLElement.h:

* Source/WebCore/html/HTMLFieldSetElement.h:

* Source/WebCore/html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::didMoveToNewDocument):
(WebCore::HTMLFormControlElement::insertedIntoAncestor):
(WebCore::HTMLFormControlElement::removedFromAncestor):
(WebCore::HTMLFormControlElement::updateWillValidateAndValidity):
(WebCore::HTMLFormControlElement::willChangeForm):
(WebCore::HTMLFormControlElement::didChangeForm):
(WebCore::HTMLFormControlElement::updateValidity):
(WebCore::HTMLFormControlElement::setCustomValidity):

* Source/WebCore/html/HTMLFormControlElement.h:
(isType):

* Source/WebCore/html/HTMLFormControlElementWithState.h:
(isType):

* Source/WebCore/html/HTMLFormControlsCollection.cpp:
(WebCore::findFormListedElement): Renamed from findFormAssociatedElement.
(WebCore::HTMLFormControlsCollection::customElementAfter const):
(WebCore::HTMLFormControlsCollection::updateNamedElementCache const): Use HashSet<AtomString> instead
of HashSet<AtomStringImpl*>.

* Source/WebCore/html/HTMLFormControlsCollection.h:

* Source/WebCore/html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::~HTMLFormElement):
(WebCore::HTMLFormElement::removedFromAncestor):
(WebCore::HTMLFormElement::length const):
(WebCore::HTMLFormElement::submitImplicitly):
(WebCore::HTMLFormElement::validateInteractively):
(WebCore::HTMLFormElement::textFieldValues const):
(WebCore::HTMLFormElement::findSubmitButton):
(WebCore::HTMLFormElement::submit):
(WebCore::HTMLFormElement::reset):
(WebCore::HTMLFormElement::resetListedFormControlElements): Renamed from
resetAssociatedFormControlElements.
(WebCore::HTMLFormElement::formElementIndexWithFormAttribute):
(WebCore::HTMLFormElement::formElementIndex):
(WebCore::HTMLFormElement::registerFormListedElement): Renamed from registerFormElement.
(WebCore::HTMLFormElement::unregisterFormListedElement): Ditto from removeFormElement.
(WebCore::HTMLFormElement::addInvalidFormControl): Renamed from registerInvalidAssociatedFormControl.
(WebCore::HTMLFormElement::removeInvalidFormControlIfNeeded): Renamed from
removeInvalidAssociatedFormControlIfNeeded.
(WebCore::HTMLFormElement::registerImgElement):
(WebCore::HTMLFormElement::unregisterImgElement): Renamed from removeImgElement for consistency.
(WebCore::HTMLFormElement::defaultButton const):
(WebCore::HTMLFormElement::checkInvalidControlsAndCollectUnhandled):
(WebCore::HTMLFormElement::assertItemCanBeInPastNamesMap const): Now takes a reference to FormNamedItem.
(WebCore::HTMLFormElement::elementFromPastNamesMap const):
(WebCore::HTMLFormElement::addToPastNamesMap): Ditto.
(WebCore::HTMLFormElement::removeFromPastNamesMap): Ditto.
(WebCore::HTMLFormElement::matchesValidPseudoClass const):
(WebCore::HTMLFormElement::namedElements):
(WebCore::HTMLFormElement::resumeFromDocumentSuspension):
(WebCore::HTMLFormElement::unsafeListedElements const): Renamed from unsafeAssociatedElements.
(WebCore::HTMLFormElement::copyListedElementsVector const): Renamed from copyAssociatedElementsVector.
(WebCore::HTMLFormElement::constructEntryList):

* Source/WebCore/html/HTMLFormElement.h:

* Source/WebCore/html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::setForm):

* Source/WebCore/html/HTMLImageElement.h:
(WebCore::HTMLImageElement::refFormAssociatedElement): Added.
(WebCore::HTMLImageElement::derefFormAssociatedElement): Added.

* Source/WebCore/html/HTMLLabelElement.cpp:

* Source/WebCore/html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::HTMLObjectElement):
(WebCore::HTMLObjectElement::insertedIntoAncestor):
(WebCore::HTMLObjectElement::removedFromAncestor):
(WebCore::HTMLObjectElement::didMoveToNewDocument):

* Source/WebCore/html/HTMLObjectElement.h:

* Source/WebCore/html/ValidityState.h:
(WebCore::FormListedElement::validity):
(WebCore::FormAssociatedElement::validity): Deleted.

* Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation elementWithName:inForm:]):
(-[WebHTMLRepresentation controlsInForm:]):

* Source/WebKitLegacy/win/WebFrame.cpp:
(WebFrame::elementWithName):
(WebFrame::controlsInForm):

Canonical link: https://commits.webkit.org/256659@main