[webkit-changes] [WebKit/WebKit] 242c63: [GTK4] GdkEvent should be managed by GRefPtr, not ...

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 242c638012ddbccb4f3b2ca5912aa74092448af1
      https://github.com/WebKit/WebKit/commit/242c638012ddbccb4f3b2ca5912aa74092448af1
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
    M Source/WebCore/platform/gtk/GUniquePtrGtk.h
    M Source/WebKit/Shared/NativeWebKeyboardEvent.h
    M Source/WebKit/Shared/NativeWebMouseEvent.h
    M Source/WebKit/Shared/NativeWebTouchEvent.h
    M Source/WebKit/Shared/NativeWebWheelEvent.h
    M Source/WebKit/Shared/gtk/NativeWebKeyboardEventGtk.cpp
    M Source/WebKit/Shared/gtk/NativeWebMouseEventGtk.cpp
    M Source/WebKit/Shared/gtk/NativeWebTouchEventGtk.cpp
    M Source/WebKit/Shared/gtk/NativeWebWheelEventGtk.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
    M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
    M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBasePrivate.h

  Log Message:
  -----------
  [GTK4] GdkEvent should be managed by GRefPtr, not GUniquePtr
https://bugs.webkit.org/show_bug.cgi?id=247092

Reviewed by Carlos Garcia Campos.

GdkEvent is now refcounted, so doesn't make sense to use GUniquePtr to
own it anymore. It's arguably useful as a cute hack to reduce
preprocessor guards, but I'd rather just handle it conditionally as
appropriate to GTK major version.

* Source/WebCore/platform/gtk/GUniquePtrGtk.h:
* Source/WebKit/Shared/NativeWebKeyboardEvent.h:
* Source/WebKit/Shared/NativeWebMouseEvent.h:
* Source/WebKit/Shared/NativeWebTouchEvent.h:
* Source/WebKit/Shared/NativeWebWheelEvent.h:
* Source/WebKit/Shared/gtk/NativeWebKeyboardEventGtk.cpp:
(WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent):
* Source/WebKit/Shared/gtk/NativeWebMouseEventGtk.cpp:
(WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
* Source/WebKit/Shared/gtk/NativeWebTouchEventGtk.cpp:
(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):
* Source/WebKit/Shared/gtk/NativeWebWheelEventGtk.cpp:
(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):
(WebKit::m_nativeEvent):
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewPopulateContextMenu):
* Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseButtonPressed):
(webkitWebViewBaseTouchEvent):
(webkitWebViewBaseTakeContextMenuEvent):
* Source/WebKit/UIProcess/API/gtk/WebKitWebViewBasePrivate.h:

Canonical link: https://commits.webkit.org/256651@main